You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And the important thing to note, here, is that this has been arranged for the convenience of Bazel. Our microservices are all written in Go with Bazel as a build tool, while our data engineering department uses Scala. We've been using Bazel and Scala so far, but I'm working on migrating away from Bazel to SBT for JVM builds.
protos/servicename2/svc2_schema.proto will import things this way:
and so forth. The already-existing sbt-protoc approach produced only protobuf errors about enum values already being defined, so I gave myself a way to directly control where to look for imports.
@thesamet: Yes, it's possible for me to replacePB.includePaths, but the problem is that because I'm replacing it, I need to duplicate the contents of sbt-protoc lines 314-319 into my config. This is generally a pretty big warning sign that I'm doing something wrong. It'll also be harder for whoever comes after me to maintain.
On the other hand, adding it as a new setting sidesteps those problems.
Sorry for the delay. Can you add to the PR a test under sbt-test/settings that demonstrates the usage of the new setting? I'd also like to validate the concern about duplicating code from sbt-protoc. If indeed duplication (or non-trivial sbt trickery) is necessary to get it to work, then I'll accept the PR which introduces this new setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've got a protobuf repo at work we need to pull in called
protobufs, and the general structure of it looks like:And the important thing to note, here, is that this has been arranged for the convenience of Bazel. Our microservices are all written in Go with Bazel as a build tool, while our data engineering department uses Scala. We've been using Bazel and Scala so far, but I'm working on migrating away from Bazel to SBT for JVM builds.
protos/servicename2/svc2_schema.protowill import things this way:and so forth. The already-existing
sbt-protocapproach produced only protobuf errors about enum values already being defined, so I gave myself a way to directly control where to look forimports.