tBTC Bridge fees reimbursement in SDK and UI #943
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the fees may be covered by Acre, so we want to display information about this in the tooltip.
❌ Deploy Preview for acre-dapp failed.
|
❌ Deploy Preview for acre-dapp-testnet failed.
|
r-czajkowski
changed the title
It represents the `ERC20` token. We need to fetch the tBTC token balance of the `ReimbursementPool` contract.
Add `bridgeFeesReimbursementThreshold` function it returns minimum deposit amount threshold for tBTC Bridge fees reimbursement. For deposits below this threshold, the fees will be reimbursed from the fees reimbursement pool.
We need to get tBTC token balance of `ReimbursementPool` contract to calculate the deposit fees correctly.
The tBTC bridge fees can be reimbursed when the deposit amount is less than or equal the reimbursement threshold. We should also take into account tBTC balance of the reimbursement pool. If there is insufficient balance in the pool, fees will be partially reimbursed.
We updated the `estimateDepositFee` function interface and we need to adjust it in the dapp.
Update copy in the tooltip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #942
For deposits below a certain threshold, the fees will be reimbursed from the fees reimbursement pool, funded by the Acre protocol.
UI changes
We want to display information that some of the fees may be covered by Acre.
Screenshots
SDK changes
BitcoinDepositor.calculateDepositFeeCheck if the tBTC bridge fees will be reimbursed. The deposit amount must be below the reimbursement threshold. This function also takes into account the tBTC balance of the reimbursement pool balance - it means fees may be covered partially.
Protocol.estimateDepositFeeChecks if the tBTC fees can be fully covered.