SearchForm Bugfix #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it was resetting searchQuery when loading PostsSingle, which triggered a new search and a router.push
Collaborator
|
Unrelated to this, but would you like to work on porting Crater to Vulcan? (http://vulcanjs.org) It'd be pretty cool to have a GraphQL-powered Crater :) |
Contributor
Author
|
Yeah, I could be down for that. Not sure how much time I could devote to it right now, though. And I'd likely need access to some production resources (db data, maybe a test production environment) in the future. So we'd need to get with Josh on that... But for now, I can play around with it on my local machine. |
Contributor
Author
|
@SachaG I noticed that this code also exists in Telescope/Vulcan, so I'm investigating... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove componentWillReceiveProps from SearchForm component
Let me know if there are any adverse effects to removing componentWillReceiveProps that I'm not aware of. This change fixes the bug behavior reported by Derek Braid here:
https://twitter.com/Royal_Arse/status/843509834314145792