Fixing bug where having no data context would break sharing #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lovetostrike @queso I closed the other pull request, rebased and then reimplemented the no data context fix. Let me know your thoughts/opinions. |
Contributor
|
I think description still needs a 'if' check or it will break the code. |
Contributor
Author
|
@lovetostrike It didn't break when I tested it out without a data context locally. I think description just ends up being null. |
Contributor
|
@BruceHubbard ah, you're right. Does it still show up as Null when you share it though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My editor also stripped out a bunch of white space, sorry about that. This change should make it so if you have no data context it'll still use the current url as the url and the page's title as the title.