Skip to content
This repository was archived by the owner on Jul 16, 2024. It is now read-only.

Conversation

bradbeam
Copy link
Contributor

Signed-off-by: Brad Beam [email protected]

@bradbeam
Copy link
Contributor Author

we should look at modifying this workflow at some point to do a build without push on pr


resources:
- github.com/thestormforge/examples/voting-webapp/application
- github.com/thestormforge/examples/webserver/voting-webapp/application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we decided to use relative paths as a convention when in the same repo, unless there is reason to fully qualify in this case?


resources:
- github.com/thestormforge/examples/voting-webapp/application
- github.com/thestormforge/examples/webserver/voting-webapp/application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as the other one.


resources:
- ../../voting-webapp/application
- github.com/thestormforge/examples/webserver/voting-webapp/application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Looks like you are going the other way. On the last PR from Tibo, we assumed people will clone the whole repo before running any of these examples.

But I do realize now, that integration tests would be one thing happening outside of this repo; is that where kustomize would break when using relative paths; I am not sure and would need to check.

@charandas
Copy link
Contributor

@bradbeam I confirmed kustomize handles github top-level path just fine, with the included kustomizations referring to relative paths. IMO, this way is the only way to guarantee what version one wants from the top level using a git sha, for instance.

If you fully qualify the paths inside the repo with github.com/..., you will always get the included paths with ref set to HEAD/main.

# This is working currently, and it uses relative paths
kustomize build github.com/thestormforge/examples/webserver/locust-metrics

@bradbeam bradbeam mentioned this pull request Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants