-
Notifications
You must be signed in to change notification settings - Fork 19
fix: Use correct path for results exporter #63
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Brad Beam <[email protected]>
Signed-off-by: Brad Beam <[email protected]>
we should look at modifying this workflow at some point to do a build without push on pr |
Signed-off-by: Brad Beam <[email protected]>
1035c84
to
8133dc5
Compare
|
||
resources: | ||
- github.com/thestormforge/examples/voting-webapp/application | ||
- github.com/thestormforge/examples/webserver/voting-webapp/application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we decided to use relative paths as a convention when in the same repo, unless there is reason to fully qualify in this case?
|
||
resources: | ||
- github.com/thestormforge/examples/voting-webapp/application | ||
- github.com/thestormforge/examples/webserver/voting-webapp/application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as the other one.
|
||
resources: | ||
- ../../voting-webapp/application | ||
- github.com/thestormforge/examples/webserver/voting-webapp/application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! Looks like you are going the other way. On the last PR from Tibo, we assumed people will clone the whole repo before running any of these examples.
But I do realize now, that integration tests would be one thing happening outside of this repo; is that where kustomize would break when using relative paths; I am not sure and would need to check.
@bradbeam I confirmed If you fully qualify the paths inside the repo with
|
Signed-off-by: Brad Beam [email protected]