basic support bidirectional stream #9

thesyncim · 2018-08-06T17:26:32Z

No description provided.

golangci · 2018-08-06T17:26:48Z

client.go

+	return 1
+}
+
+func (c *Client) CallStream(opname string, req, resp Message, handleStream func(client *StreamClient) error) error {


undeclared name: StreamClient

golangci · 2018-08-06T17:26:48Z

server.go

 }

-func (s *Server) handleRequest(wi *serverWorkItem, pendingResponses chan<- *serverWorkItem, stopCh <-chan struct{}) {
+func (s *Server) handleRequest(wi *serverWorkItem, pendingResponses chan<- *serverWorkItem, stream *StreamServer, stopCh <-chan struct{}) {


undeclared name: StreamServer

golangci · 2018-08-06T17:26:48Z

client.go

+	//
+	// This saves memory and CPU resources.
+
+	s := NewStreamClient(sid, xxhash.Sum64String(opname), c.opts.Codec, in, func(id uint32, m *request, resp chan error) {


undeclared name: NewStreamClient

golangci · 2018-08-06T17:26:48Z

server.go

 				continue
 			}
+
+			var stream *StreamServer


undeclared name: StreamServer

golangci · 2018-08-06T17:26:48Z

server.go

+				in := make(chan *request, 1)
+				streamID := binary.BigEndian.Uint32(wi.streamID[:])
+				s.inStreamMsg[streamID] = in
+				stream = NewServerStream(streamID, s.opts.Codec, in, func(id uint32, m *response, resp chan error) {


undeclared name: NewServerStream

golangci · 2018-08-06T17:26:49Z

stream_test.go

+	var request = strconv.Itoa(t.N / 2)
+	var response = ""
+
+	err := c.CallStream("stream", &request, &response, func(client *StreamClient) error {


undeclared name: StreamClient

golangci · 2018-08-06T17:26:49Z

stream_test.go

+		t.ResetTimer()
+		t.ReportAllocs()
+
+		err := client.SendMsg(request)


invalid operation: client (variable of type *invalid type) has no field or method SendMsg

golangci · 2018-08-06T17:26:49Z

stream_test.go

+		var r string
+
+		for i := 0; i < t.N/2; i++ {
+			err = client.RecvMsg(&r)


invalid operation: client (variable of type *invalid type) has no field or method RecvMsg

golangci · 2018-08-06T17:28:53Z

handler.go

 	reply := opinfo.ReplyType()

-	if err = handler(nil, args, reply); err != nil {
+	if err = handler(&Context{stream}, args, reply); err != nil {


github.com/thesyncim/exposed.Context composite literal uses unkeyed fields

golangci · 2018-08-06T17:28:53Z

client.go

+			ReleaseResponse(rawResp)
+			releaseClientWorkItem(wi)
+			c.decPendingRequests()
+			c.getError(err)


Error return value of c.getError is not checked

golangci · 2018-08-06T17:28:53Z

client.go

+			ReleaseResponse(rawResp)
+			releaseClientWorkItem(wi)
+			c.decPendingRequests()
+			c.getError(err)


Error return value of c.getError is not checked

golangci · 2018-08-06T17:28:53Z

client.go

+			ReleaseResponse(rawResp)
+			releaseClientWorkItem(wi)
+			c.decPendingRequests()
+			c.getError(err)


Error return value of c.getError is not checked

golangci · 2018-08-06T17:28:54Z

stream.go

+	codec encoding.Codec
+
+	inMessages chan *request
+	errOutCh   chan error


errOutCh is unused

golangci · 2018-08-06T17:28:54Z

stream.go

+
+type StreamClient struct {
+	ID       uint32
+	isServer bool


isServer is unused

golangci · 2018-08-06T17:28:54Z

stream.go

+	codec encoding.Codec
+
+	inMessages <-chan *response
+	errOutCh   chan error


errOutCh is unused

golangci · 2018-08-06T17:28:55Z

client.go

 	pendingResponsesLock sync.Mutex

+	incomingStreamMsg     sync.Map
+	incomingStreamMsgLock sync.Mutex


incomingStreamMsgLock is unused

golangci · 2018-08-06T17:28:55Z

server.go

 }

+var (
+	typeUnarycall = []byte{byte(0)}


typeUnarycall is unused

golangci · 2018-08-06T17:28:55Z

stream_test.go

+			if err != nil {
+				t.Fatal(err)
+			}
+			if i == 99 {


empty branch

make stream thread safe improve and reorganize code

golangci · 2018-08-07T20:42:28Z

server.go

 		close(stopCh)
+		inStreamMsg.Range(func(key, value interface{}) bool {
+			panic("das")
+			close(value.(chan *request))


unreachable code

golangci · 2018-08-07T20:42:28Z

server.go

 		conn.Close()
+		inStreamMsg.Range(func(key, value interface{}) bool {
+			panic("das")
+			close(value.(chan *request))


unreachable code

golangci · 2018-08-07T20:42:28Z

protocol.go

+	streamMessage = packetControl(1)
+	streamStart   = packetControl(2)
+	///todo implement
+	streamClose      = packetControl(3)


streamClose is unused

golangci · 2018-08-07T20:42:28Z

protocol.go

+	streamStart   = packetControl(2)
+	///todo implement
+	streamClose      = packetControl(3)
+	streamCloseRead  = packetControl(4)


streamCloseRead is unused

golangci · 2018-08-07T20:42:28Z

protocol.go

+	///todo implement
+	streamClose      = packetControl(3)
+	streamCloseRead  = packetControl(4)
+	streamCloseWrite = packetControl(5)


streamCloseWrite is unused

golangci · 2018-08-07T20:42:29Z

stream.go

+	inMessages        <-chan *response
+	serverOutMessages chan<- WorkItem
+
+	errOutCh chan error


errOutCh is unused

golangci · 2018-08-07T20:42:30Z

stream.go

+	codec encoding.Codec
+
+	inMessages        <-chan *response
+	serverOutMessages chan<- WorkItem


serverOutMessages is unused

golangci · 2018-08-07T20:42:30Z

server.go

-	reqID [4]byte
+type serverUnaryWorkItem struct {
+	ctx         *exposedCtx
+	startStream bool


startStream is unused

golangci · 2018-08-07T20:42:30Z

stream_test.go

+			if err != nil {
+				t.Fatal(err)
+			}
+			if i == 99 {


empty branch

golangci · 2018-08-07T20:42:30Z

client.go

+	})
+	sid := c.nextStreamID()
+	inStream, _ := c.incomingStreamMsg.LoadOrStore(sid, make(chan *response, 100))
+	var in chan *response


should merge variable declaration with assignment on next line

codecov · 2018-08-07T20:43:04Z

Codecov Report

Merging #9 into master will decrease coverage by 13.76%.
The diff coverage is 24.73%.

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
- Coverage   66.84%   53.08%   -13.77%     
===========================================
  Files           9       10        +1     
  Lines         926     1217      +291     
===========================================
+ Hits          619      646       +27     
- Misses        239      487      +248     
- Partials       68       84       +16

Impacted Files	Coverage Δ
register.go	`0% <ø> (ø)`	⬆️
handler.go	`37.5% <0%> (ø)`	⬆️
stream.go	`0% <0%> (ø)`
client.go	`51.41% <25.5%> (-15.96%)`	⬇️
server.go	`57% <35.96%> (-16.12%)`	⬇️
request.go	`71.79% <0%> (-5.13%)`	⬇️
common.go	`65.49% <0%> (-1.17%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b3f89...878b31e. Read the comment docs.

basic support bidirectional stream

d9c258e

golangci reviewed Aug 6, 2018

View reviewed changes

add missing stream.go

bf7601a

golangci reviewed Aug 6, 2018

View reviewed changes

thesyncim added 2 commits August 7, 2018 19:13

add protocol structures

f05545f

make stream thread safe improve and reorganize code

improve code

878b31e

golangci reviewed Aug 7, 2018

View reviewed changes

Repository owner deleted a comment from yuvicc Feb 23, 2024

basic support bidirectional stream #9

Are you sure you want to change the base?

basic support bidirectional stream #9

Uh oh!

Conversation

thesyncim commented Aug 6, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Aug 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Aug 7, 2018 •

edited

Loading