Store country band details in database #10476
Conversation
danieljames-dj
force-pushed
the
country_band_details
branch
15 times, most recently
from
d02c82a to
9c50e1a
Compare
danieljames-dj
force-pushed
the
country_band_details
branch
2 times, most recently
from
bf747ae to
b4fe1d2
Compare
danieljames-dj
force-pushed
the
country_band_details
branch
from
b4fe1d2 to
91c0294
Compare
danieljames-dj
force-pushed
the
country_band_details
branch
from
91c0294 to
e28d6cc
Compare
| country_band = CountryBand.find_by(iso2: country_iso2)&.number | ||
| country_band_detail = CountryBandDetail.find_by(number: country_band) |
There was a problem hiding this comment.
You're completely ignoring your new belongs_to association here.
|
|
||
| [registration_fee_dues_us_dollars, country_band_dues_us_dollars_money].max | ||
| # Calculation of 'country band dues' | ||
| country_band_dues = Money.new(country_band_detail&.due_amount_per_competitor_in_cents || 0, "USD") |
There was a problem hiding this comment.
Too much happening in one line
| # times 100 because Money require lowest currency subunit, which is cents for USD | ||
| country_band_dues_us_dollars_money = Money.new(country_band_dues_us_dollars * 100, "USD") | ||
| # Calculation of 'registration fee dues' | ||
| registration_fee_dues = Money.new(registration_fees * (country_band_detail&.due_percent_registration_fee.to_f || 0) / 100, "USD") |
There was a problem hiding this comment.
Too much happening in one line
| belongs_to :country, foreign_key: :iso2, primary_key: :iso2 | ||
| belongs_to :country_band_detail, foreign_key: :number, primary_key: :number |
There was a problem hiding this comment.
I don't fully understand the idea behind this CountryBandDetails model. It has a start date and an end date, but every CountryBand (which is perpetual/static) contains a column which points it to exactly one CountryBandDetail.
That means, you could point Band 5 to a CountryBandDetail from 3 years ago, which isn't even valid anymore.
I know you will probably tell me that "WFC will prevent that" but I want to challenge you to see whether you can come up with some better database design first to avoid these problems from happening in the first place
This PR aims at removing some hard-coding related to dues details. This will help to make the changes quickly in case we need to make some change in dues in future.