Port edit profile to react #10644
Open
Port edit profile to react #10644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Tried way too long trying to replicate the requests for Rails in the preference tab, but had to make a new route for it in the end because it was just too spaghetti |
|
Should be feature complete now. There is definitely some room for refactoring like the creating a shared component for the authenticity token hidden field that is required for rails form requests |
|
Will also need to have some custom styling for the general page |
|
General Page: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have only done the scaffolding so far, the pro is that the RolesTab and the Edit Avatar Tab is already migrated