Periodic EEQ-BC implementation complete - #3
Merged
Conversation
lmseidler
commented
Aug 15, 2025
lmseidler
commented
- finished implementation of periodic functions
- added tests to pbc implementation
Transfer bug fixes to no ewald branch
thfroitzheim
requested changes
Aug 15, 2025
thfroitzheim
left a comment
thfroitzheim
left a comment
Owner
There was a problem hiding this comment.
Looks already good. Mainly a few formatting things.
Co-authored-by: Thomas Froitzheim <92028749+thfroitzheim@users.noreply.github.com>
Co-authored-by: Thomas Froitzheim <92028749+thfroitzheim@users.noreply.github.com>
Co-authored-by: Thomas Froitzheim <92028749+thfroitzheim@users.noreply.github.com>
Co-authored-by: Thomas Froitzheim <92028749+thfroitzheim@users.noreply.github.com>
Co-authored-by: Thomas Froitzheim <92028749+thfroitzheim@users.noreply.github.com>
Co-authored-by: Thomas Froitzheim <92028749+thfroitzheim@users.noreply.github.com>
thfroitzheim
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.