-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings for most commonly used API #2
Open
zeitstein
wants to merge
14
commits into
thheller:master
Choose a base branch
from
zeitstein:docstrings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zeitstein thank you for writing this - as someone new to the library this was a very helpful PR to read! |
zeitstein
changed the title
init add docstrings
Add docstrings for most commonly used API
Jul 13, 2023
rschmukler
pushed a commit
to rschmukler/shadow-grove
that referenced
this pull request
Jul 13, 2023
Identical content to thheller#2, just cleans up the commit log. All credit goes to @zeitstein
rschmukler
pushed a commit
to rschmukler/shadow-grove
that referenced
this pull request
Jul 13, 2023
Identical content to thheller#2, just cleans up the commit log. All credit goes to @zeitstein
rschmukler
pushed a commit
to rschmukler/shadow-grove
that referenced
this pull request
Jul 13, 2023
Identical content to thheller#2, just cleans up the commit log. All credit goes to @zeitstein
rschmukler
pushed a commit
to rschmukler/shadow-grove
that referenced
this pull request
Jul 13, 2023
Identical content to thheller#2, just cleans up the commit log. All credit goes to @zeitstein
rschmukler
pushed a commit
to rschmukler/shadow-grove
that referenced
this pull request
Jul 13, 2023
Identical content to thheller#2, just cleans up the commit log. All credit goes to @zeitstein
rschmukler
pushed a commit
to rschmukler/shadow-grove
that referenced
this pull request
Jul 14, 2023
Identical content to thheller#2, just cleans up the commit log. All credit goes to @zeitstein
rschmukler
pushed a commit
to rschmukler/shadow-grove
that referenced
this pull request
Apr 23, 2024
Identical content to thheller#2, just cleans up the commit log. All credit goes to @zeitstein
rschmukler
pushed a commit
to rschmukler/shadow-grove
that referenced
this pull request
Apr 23, 2024
Identical content to thheller#2, just cleans up the commit log. All credit goes to @zeitstein
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docstrings to most commonly used API.
I plan on adding docs to
defc
,<<
, etc, as well.Also have this lengthy
http-fx
example which I chose not to include. Let me know if I should.