fix #6923 dnnHelperTip causes horizontal scrollbar when moving mouse…#4
Open
fix #6923 dnnHelperTip causes horizontal scrollbar when moving mouse…#4
Conversation
…ving mouse to the right edge (dnn.jquery.js) fix dnnsoftware#6923 dnnHelperTip causes horizontal scrollbar when moving mouse to the right edge (dnn.jquery.js) ## Description This PR fixes issue dnnsoftware#6923 where the `dnnHelperTip` causes a horizontal scrollbar when the mouse moves to the right edge of the screen. I added logic to calculate the viewport width and constrain the tooltip position. ## Changes - Modified `dnn.jquery.js` to clamp the tooltip X coordinate within the window width. ## RFC / Future Consideration While this PR resolves the immediate scrolling issue, I would like to propose (RFC) fully deprecating this JavaScript-based "mouse-follow" behavior in favor of a pure CSS implementation. Moving to CSS would simplify the codebase and provide a lighter, more stable UI/UX for the Admin interface. PS: If there is consensus on this approach, I can proceed with a PR to refactor this feature. The helper tip will be static and centered relative to the Module title, completely removing the mouse-tracking behavior.
dnnsoftware#6916 was merged with whitespace issues, this PR fixes that
Fixed whitespace issues in default.aspx.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to the right edge (dnn.jquery.js)
fix dnnsoftware#6923
dnnHelperTip causes horizontal scrollbar when moving mouse to the right edge (dnn.jquery.js) ## Description
This PR fixes issue dnnsoftware#6923 where the
dnnHelperTipcauses a horizontal scrollbar when the mouse moves to the right edge of the screen. I added logic to calculate the viewport width and constrain the tooltip position.Changes
dnn.jquery.jsto clamp the tooltip X coordinate within the window width.RFC / Future Consideration
While this PR resolves the immediate scrolling issue, I would like to propose (RFC) fully deprecating this JavaScript-based "mouse-follow" behavior in favor of a pure CSS implementation. Moving to CSS would simplify the codebase and provide a lighter, more stable UI/UX for the Admin interface. PS: If there is consensus on this approach, I can proceed with a PR to refactor this feature. The helper tip will be static and centered relative to the Module title, completely removing the mouse-tracking behavior.
Summary