Fix several issues and improve performance #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmohr
force-pushed
the
fixing-stuff
branch
6 times, most recently
from
d11b3b5 to
68df5f0
Compare
thilo-schmitt
requested changes
Jan 7, 2024
alexmohr
force-pushed
the
fixing-stuff
branch
2 times, most recently
from
ab6075b to
b1ec308
Compare
files which grow or shrink are now supported properly if output mode is file, the header will be patched according to the actual amount of read data. This mode also supports reading files from /proc/. In streaming mode, the size will be fixed at the start of reading the input. Files which change in size are handled properly here as well, but due streaming output does not support reading files from /proc/ properly as it depends on a known size before reading which is not possible with the virtual filesytem in /proc Signed-off-by: Alexander Mohr <[email protected]>
this commit fixes how symlinks are handled. tarxx now behaves like gnu tar in this regard and the path of link is not converted into a relative format. Signed-off-by: Alexander Mohr <[email protected]>
this commit improves the runtime without compression to only a third compared to the previous result. Signed-off-by: Alexander Mohr <[email protected]>
this commit fixes handling of blocks with size 0 Signed-off-by: Alexander Mohr <[email protected]>
posix function to get groups and users are not thread safe. Some operating system implement them more or less thread safe but others don't. Refactor to use the thread safe api to prevent segmentation faults Signed-off-by: Alexander Mohr <[email protected]>
Signed-off-by: Alexander Mohr <[email protected]>
|
Thank you for bearing with me. Looks good now. Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21
Alexander Mohr, [email protected], Mercedes-Benz Tech Innovation GmbH, imprint