Skip to content

Require callback on commit #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 90 commits into
base: v2
Choose a base branch
from
Open

Require callback on commit #186

wants to merge 90 commits into from

Conversation

@broder
Copy link

@broder broder commented Dec 24, 2015

Hopefully solves: #170 by ensuring that a callback is passed (rather than making the callback optional)

aseemk added 30 commits June 11, 2015 09:32
@aseemk
v2 / Tests: flesh out; begin core tests!
f03a475
@aseemk
v2 / Core: begin new lib, GraphDatabase class.
71e18b3
@aseemk
v2 / Tests: improve/DRY up core tests.
0c6bb3b
@aseemk
v2 / Errors: API, tests, partial impl.
889d76b
@aseemk
v2 / Tests: split up constructor and HTTP tests.
90c3c68
@aseemk
v2 / Core: impl. and test parsing of nodes & rels!
374037a
@aseemk
v2 / Errors: improve impl. and tests.
810aec1
@aseemk
v2 / Tests: update Travis; fix for older Neo4j versions.
f7ebcf6
@aseemk
v2 / Cypher: impl. and test single queries!
c3b4063
@aseemk
v2 / Tests: de-dupe test graph queries and logic.
219ef48
@aseemk
v2 / Transactions: impl. and test thoroughly!
f5ed54c
@aseemk
v2 / Batching: spec out, impl., and add tests!
7805d62
@aseemk
v2 / Cypher: more efficient impl. for raw queries.
ba7f36e 
No need to traverse the response body looking for REST
format nodes & relationships when there won’t be any.
@aseemk
v2 / Cypher: change API from raw to lean!
18e1380 
Clearer and more precise name.
@aseemk
v2 / Tests: reduce Mocha time thresholds.
899fec0 
We no longer have such slow tests. Woohoo!
@aseemk
v2 / HTTP: impl. and test streaming!
1e31047
@aseemk
v2 / Misc: update version, since breaking change.
e89145b
@aseemk
v2 / HTTP: add support for custom agent, proxy, gzip.
eb10a2a
@aseemk
v2 / Schema: impl. and test labels and misc.
d6b4ac2
@aseemk
v2 / Misc: bump alpha version to 3.
9ab3808
@aseemk
v2 / Docs: remove Codo.
3b4c2db 
Unfortunately it seems broken at the moment:

coffeedoc/codo#194
coffeedoc/codo#195

And the auto-webhook site is down too:

coffeedoc/coffeedoc.info#9

Given these issues, going to just write docs manually.
@aseemk
v2 / Docs: WIP readme
2a0ec94
@aseemk
v2 / Errors: include Neo4j stack on database errors!
6cdaa2a
@aseemk
v2 / Misc: bump alpha version to 4.
555adef
@aseemk
v2 / Misc: rename index.coffee to exports.coffee.
8ac4d27 
To pave the way for an Index class.
@aseemk
v2 / Tests: update Travis to Neo4j 2.1.7.
91d2290
@aseemk
v2 / Core: work around Neo4j 2.1.7 hyperlink bug.
08ae578
@aseemk
v2 / Tests: trigger standalone DatabaseError.
2cee8ec
@aseemk
v2 / Tests: add transactional "first query" tests.
d8e0e8d
@aseemk
v2 / Tests: test transaction commit before any queries.
16d910a
aseemk and others added 28 commits November 7, 2015 23:37
@aseemk
v2 / Tests: test Neo4j 2.3.0-M01 in CI.
d1751ec
@aseemk
v2 / Transactions: add proper state enum/constants.
d6984b2
@aseemk
v2 / Schema: improve index & constraint idempotence.
2954eec
@aseemk
v2 / Misc: update version to 2.0.0-RC2.
fc25ee8
@aseemk
v2 / Docs: move dev info to new CONTRIBUTING.md. [skip ci]
cef9cba
@aseemk
fix "v2 / Tests: flesh out"
d9dd176
@aseemk
v2 / Docs: flesh out CONTRIBUTING.md.
42aea19
@aseemk
v2 / Docs: overhaul readme; start manual. [skip ci]
caa94fc
@aseemk
v2 / Docs: document transactions! [skip ci]
8ff48bd
@aseemk
v2 / Docs: document header support; linkify; misc. [skip ci]
8d312f6
@aseemk
v2 / Docs: document high availability! [skip ci]
9fd06c8
@aseemk
v2 / Docs: document HTTP / plugins! [skip ci]
81d03eb
@aseemk
v2 / Docs: TODOs / WIP
4ec5ae3
@aseemk
v2 / Docs: lots 'o improvements. [skip ci]
44f93d7
@aseemk
v2 / Misc: fix package.json spacing. [skip ci]
7657e85
@aseemk
v2 / Tests: use exports instead of @.
a710495 
For Streamline 1.0 / Babel / ES6.
@aseemk
v2 / Tests: upgrade to Streamline 1.0!
c69d96e
@aseemk
Revert "v2 / Tests: upgrade to Streamline 1.0!"
e3082b6 
This reverts commit 42b73f4f618cef89ebc17710b656608a2f5bdcdf.
@aseemk
v2 / Tests: add Node.js v4 and v5 to Travis CI.
2869c06
@aseemk
v2 / Tests: update Neo4j versions in Travis CI.
c4e06bd
@aseemk
v2 / Tests: fix & update transaction tests for Neo4j 2.2.6.
baaee08
@aseemk
v2 / Tests: add test for (deadlock detected) transient error!
a755af7
@aseemk
v2 / Tests: improve order of transaction tests.
65a7be3
@aseemk
v2 / Tests: work around Neo4j NoSuchIndex error regression.
7537d17
@aseemk
v2 / Tests: fix/update constraint rollback for Neo4j 2.2.6.
2d932db
@aseemk
v2 / Tests: increase constraint timeout for large dbs.
334d0c1
@aseemk
v2 / Tests: work around Neo4j 2.3 disabling index hint errors.
7670748
Require callback on commit
6b5a99e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@broder @aseemk @cheerfulstoic