Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Revisions: In-app & ecosystem wallet FAQs page, Pay -> Univ Bridge, Wallets Get Started #6494

Merged
merged 8 commits into from
Mar 20, 2025

Conversation

pinkhoodie
Copy link
Contributor

@pinkhoodie pinkhoodie commented Mar 18, 2025


PR-Codex overview

This PR refines the documentation and code related to the thirdweb platform, transitioning references from Pay to Universal Bridge, and adds FAQ sections for in-app and ecosystem wallets.

Detailed summary

  • Updated metadata titles and descriptions to reflect Universal Bridge.
  • Added FAQ sections in sidebar.tsx and new pages for in-app and ecosystem wallet FAQs.
  • Revised content in get-started and quickstart pages to refer to Universal Bridge.
  • Enhanced get-started page with wallet integration instructions across various platforms.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@pinkhoodie pinkhoodie requested review from a team as code owners March 18, 2025 17:41
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 35aff2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 1:43am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 1:43am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 1:43am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 1:43am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 1:43am

Copy link
Contributor

graphite-app bot commented Mar 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.77%. Comparing base (d14a78c) to head (35aff2f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6494   +/-   ##
=======================================
  Coverage   54.77%   54.77%           
=======================================
  Files         875      875           
  Lines       54903    54903           
  Branches     3739     3739           
=======================================
  Hits        30073    30073           
  Misses      24735    24735           
  Partials       95       95           
Flag Coverage Δ
packages 54.77% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.92 KB (0%) 939 ms (0%) 202 ms (+144.19% 🔺) 1.2 s
thirdweb (cjs) 127.17 KB (0%) 2.6 s (0%) 305 ms (+31.08% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 111 ms (+1471.25% 🔺) 223 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 51 ms (+1601.01% 🔺) 61 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 102 ms (+448.15% 🔺) 489 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 19, 2025 17:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 19, 2025 17:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 19, 2025 17:26 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 19, 2025 17:26 Inactive
@@ -3,7 +3,7 @@ import { createMetadata, Callout } from "@doc";

export const metadata = createMetadata({
image: {
title: "thirdweb Pay - Test Mode",
title: "thirdweb Universal Bridge - Test Mode",
icon: "thirdweb",
},
title: "Enable Test Mode for Universal bridge — thirdweb docs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The capitalization of "Universal bridge" should be standardized to "Universal Bridge" to maintain consistent capitalization throughout the documentation. This inconsistency appears only in this title while other instances use the proper capitalization format.

Suggested change
title: "Enable Test Mode for Universal bridge — thirdweb docs",
title: "Enable Test Mode for Universal Bridge — thirdweb docs",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.


**Branded Wallet Connector**

Partners can add your wallet as a wallet connector option in their existing sign in flow on any domains they've whitelisted by calling the follow endpoint from their application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a small typo in this sentence. "calling the follow endpoint" should be "calling the following endpoint" to maintain proper grammar.

Suggested change
Partners can add your wallet as a wallet connector option in their existing sign in flow on any domains they've whitelisted by calling the follow endpoint from their application.
Partners can add your wallet as a wallet connector option in their existing sign in flow on any domains they've whitelisted by calling the following endpoint from their application.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@pinkhoodie pinkhoodie changed the title In-app & ecosystem wallet FAQs page, Pay -> Univ Bridge, Docs Revisions: In-app & ecosystem wallet FAQs page, Pay -> Univ Bridge, Wallets Get Started Mar 19, 2025
…e examples, robust features section, and framework-specific implementations
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 20, 2025 01:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 20, 2025 01:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 20, 2025 01:30 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 20, 2025 01:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants