WIP: Support stylus contracts publish and deploy #6495
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| const url = new URL( | ||
| `${THIRDWEB_URL} | ||
| /contracts/${command}/ | ||
| ${encodeURIComponent(hash.replace("ipfs://", ""))}`, |
There was a problem hiding this comment.
The URL template string contains newlines and whitespace that will be included in the final URL, which will cause navigation issues. This should be rewritten as a single-line string:
const url = new URL(`${THIRDWEB_URL}/contracts/${command}/${encodeURIComponent(hash.replace("ipfs://", ""))}`);| const url = new URL( | |
| `${THIRDWEB_URL} | |
| /contracts/${command}/ | |
| ${encodeURIComponent(hash.replace("ipfs://", ""))}`, | |
| const url = new URL( | |
| `${THIRDWEB_URL}/contracts/${command}/${encodeURIComponent(hash.replace("ipfs://", ""))}`, |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| }); | ||
|
|
||
| const url = getUrl(publishUri, "publish").toString(); | ||
| spinner.succeed(`Upload complete:, ${url}`); |
There was a problem hiding this comment.
There's a small typo in the success message - the comma after "Upload complete:" is unnecessary and makes the message read awkwardly. Consider changing to:
spinner.succeed(`Upload complete: ${url}`);This will display a cleaner message to users when their upload finishes.
| spinner.succeed(`Upload complete:, ${url}`); | |
| spinner.succeed(`Upload complete: ${url}`); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6495 +/- ##
==========================================
- Coverage 54.82% 54.82% -0.01%
==========================================
Files 875 875
Lines 54851 54849 -2
Branches 3740 3737 -3
==========================================
- Hits 30071 30069 -2
- Misses 24685 24686 +1
+ Partials 95 94 -1
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR introduces new features and improvements in the
thirdwebpackage, including the addition of apublish-styluscommand, enhancements to contract deployment options withextraData, and improvements in fetching compiler metadata.Detailed summary
publishStylusfunction inpackages/thirdweb/src/cli/commands/publish-stylus/publish-stylus.ts.secretKeyhandling inpackages/thirdweb/src/cli/bin.ts.deployContractto includeextraData.getCompilerMetadata.deploy-with-abi.tsto handleextraDatain contract deployment.package.jsonincludingchalk,open, andora.