Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDk] fix: Improve multistep swap UI in PayEmbed #6503

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 20, 2025


PR-Codex overview

This PR focuses on UI cleanup for multistep swaps in the PayEmbed, specifically improving the StepConnectorArrow component and adjusting its usage across various screens.

Detailed summary

  • Updated StepConnectorArrow to remove the active prop.
  • Simplified rendering logic in OnRampScreen for StepConnectorArrow.
  • Changed the appearance of StepConnectorArrow to use a Container with a background and border instead of SVG paths.
  • Adjusted styles for better spacing and alignment.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:07am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:07am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:07am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:07am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:07am

Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 3dac0f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 20, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title [UI] fix: Improve multistep swaps in PayEmbed [SDk] fix: Improve multistep swap UI in PayEmbed Mar 20, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review March 20, 2025 06:55
@joaquim-verges joaquim-verges requested review from a team as code owners March 20, 2025 06:55
@joaquim-verges joaquim-verges force-pushed the _UI_fix_Improve_multistep_swaps_in_PayEmbed branch from 200f077 to 8a91edd Compare March 20, 2025 06:57
Copy link
Contributor

github-actions bot commented Mar 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.92 KB (0%) 939 ms (0%) 135 ms (+175.13% 🔺) 1.1 s
thirdweb (cjs) 127.17 KB (0%) 2.6 s (0%) 173 ms (+7.52% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 45 ms (+778.76% 🔺) 157 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 21 ms (+1183.13% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 70 ms (+296.85% 🔺) 457 ms

@joaquim-verges joaquim-verges merged commit 47f8cd6 into main Mar 20, 2025
29 of 30 checks passed
@joaquim-verges joaquim-verges deleted the _UI_fix_Improve_multistep_swaps_in_PayEmbed branch March 20, 2025 07:08
@joaquim-verges joaquim-verges mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant