Skip to content

Remove Pack from explore #6781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Conversation

kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Apr 21, 2025


PR-Codex overview

This PR removes the thirdweb.eth/Pack entry from the GAMING constant in the explore.ts file, indicating a potential update in the gaming-related assets available for exploration.

Detailed summary

  • Removed thirdweb.eth/Pack from the GAMING constant array in apps/dashboard/src/data/explore.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners April 21, 2025 11:42
Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: 023fa29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:22am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:22am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:22am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:22am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:22am

Copy link
Contributor

graphite-app bot commented Apr 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

github-actions bot commented Apr 21, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.8 KB (0%) 1.1 s (0%) 98 ms (+52.98% 🔺) 1.2 s
thirdweb (cjs) 138.95 KB (0%) 2.8 s (0%) 183 ms (+16.88% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.63 KB (0%) 113 ms (0%) 44 ms (+814.03% 🔺) 156 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 22 ms (+1033.46% 🔺) 32 ms
thirdweb/react (minimal + tree-shaking) 19.45 KB (0%) 389 ms (0%) 41 ms (+201.58% 🔺) 430 ms

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we split this into multiple PRs?

  1. disable pack in dashboard
  2. remove pack from SDK (needs AT LEAST a minor version, should REALISTICALLY be a major version)

Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would not remove the pack code entirely.

we still have the Chainlink version which still works and uses the same SDK code

@kumaryash90
Copy link
Member Author

would not remove the pack code entirely.

we still have the Chainlink version which still works and uses the same SDK code

Or I can just remove the deploy functions from export for now? @joaquim-verges

@kumaryash90 kumaryash90 force-pushed the yash/cleanup-obsolete-contracts branch from 21b71e1 to cd5402d Compare April 23, 2025 08:09
@vercel vercel bot temporarily deployed to Preview – login April 23, 2025 08:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 23, 2025 08:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 23, 2025 08:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 23, 2025 08:09 Inactive
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (8b4b873) to head (023fa29).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6781   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56951    56951           
  Branches     3946     3946           
=======================================
  Hits        31430    31430           
  Misses      25425    25425           
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 683e3b0 into main Apr 23, 2025
20 of 22 checks passed
@joaquim-verges joaquim-verges deleted the yash/cleanup-obsolete-contracts branch April 23, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants