Skip to content

[SDK] Fix: update bridge tests #6785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

[SDK] Fix: update bridge tests #6785

merged 2 commits into from
Apr 21, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Apr 21, 2025


PR-Codex overview

This PR focuses on improving error handling in various functions by including correlationId in the error messages and updating test cases to reflect new destination chain IDs.

Detailed summary

  • Updated error messages in Status.ts, Buy.ts, Sell.ts to include correlationId.
  • Changed destinationChainId from 10 to 444 in multiple test cases.
  • Updated sender and receiver addresses in test cases for Buy and Sell.
  • Removed specific error message expectations in tests, now using general error checks.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners April 21, 2025 17:45
Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: 7d97b8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 6:01pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 6:01pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 6:01pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 6:01pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 6:01pm

Copy link
Contributor

graphite-app bot commented Apr 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

github-actions bot commented Apr 21, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.76 KB (+0.1% 🔺) 1.1 s (+0.1% 🔺) 334 ms (+107.62% 🔺) 1.4 s
thirdweb (cjs) 138.9 KB (+0.06% 🔺) 2.8 s (+0.06% 🔺) 486 ms (+25.76% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 85 ms (+657.45% 🔺) 197 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 45 ms (+362.72% 🔺) 55 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (0%) 388 ms (0%) 104 ms (+200.73% 🔺) 491 ms

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.18%. Comparing base (67768ac) to head (7d97b8f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/bridge/Status.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6785   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56924    56934   +10     
  Branches     3943     3943           
=======================================
+ Hits        31412    31420    +8     
- Misses      25416    25418    +2     
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <80.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
packages/thirdweb/src/bridge/Buy.ts 96.80% <100.00%> (+0.14%) ⬆️
packages/thirdweb/src/bridge/Sell.ts 96.80% <100.00%> (+0.14%) ⬆️
packages/thirdweb/src/utils/domains.ts 100.00% <ø> (ø)
packages/thirdweb/src/bridge/Status.ts 43.13% <0.00%> (-1.77%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant