You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR focuses on improving error handling in various functions by including correlationId in the error messages and updating test cases to reflect new destination chain IDs.
Detailed summary
Updated error messages in Status.ts, Buy.ts, Sell.ts to include correlationId.
Changed destinationChainId from 10 to 444 in multiple test cases.
Updated sender and receiver addresses in test cases for Buy and Sell.
Removed specific error message expectations in tests, now using general error checks.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving error handling in various functions by including
correlationId
in the error messages and updating test cases to reflect new destination chain IDs.Detailed summary
Status.ts
,Buy.ts
,Sell.ts
to includecorrelationId
.destinationChainId
from10
to444
in multiple test cases.Buy
andSell
.