[TOOL-4228] Dashboard: Add file upload for in-app wallet branding form tool-4228 #6811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
jnsdls
approved these changes
Apr 22, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/dashboard/src/components/embedded-wallets/Configure/index.tsx
Outdated
Show resolved
Hide resolved
size-limit report 📦
|
MananTank
force-pushed
the
04-22-_tool-4228_dashboard_add_file_upload_for_in-app_wallet_branding_form_tool-4228
branch
from
b96bd97 to
9b5d9b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6811 +/- ##
=======================================
Coverage 55.18% 55.18%
=======================================
Files 896 896
Lines 56940 56940
Branches 3943 3943
=======================================
Hits 31420 31420
Misses 25424 25424
Partials 96 96
🚀 New features to boost your workflow:
|
Merge activity
|
…m tool-4228 (#6811) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `BrandingFieldset` component by introducing an `AppImageFormControl` for managing application images, while also refining the handling of branding properties in the form. ### Detailed summary - Added `Team` type import. - Introduced `useThirdwebClient` and `resolveSchemeWithErrorHandler`. - Modified `BrandingFieldset` to swap `applicationName` and `applicationImageUrl` fields. - Created `AppImageFormControl` for image upload handling. - Integrated image upload logic with error handling using `toast`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
04-22-_tool-4228_dashboard_add_file_upload_for_in-app_wallet_branding_form_tool-4228
branch
from
9b5d9b3 to
8dc27ff
Compare
graphite-app
bot
deleted the
04-22-_tool-4228_dashboard_add_file_upload_for_in-app_wallet_branding_form_tool-4228
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the
BrandingFieldsetcomponent by modifying how application branding information is handled. It introduces a new image upload feature for the application logo and rearranges form fields for better clarity.Detailed summary
AppImageFormControlcomponent for image uploading.branding.applicationNameandbranding.applicationImageUrlfields inBrandingFieldset.useThirdwebClientanduploadmethod.