Skip to content

[NEB-180] Update Nebula context selection UI, add wallet switcher #6814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Apr 22, 2025


PR-Codex overview

This PR focuses on integrating ThirdwebClient across several components and improving the handling of network and chain data within the application. It also removes some redundant code and refines the structure of several files.

Detailed summary

  • Removed ContextFilters.tsx and ContextFilters.stories.tsx.
  • Updated auth-actions.ts to include chainId in the JSON body.
  • Added thirdwebClient to various components for enhanced functionality.
  • Modified ChainIconClient to utilize src instead of ipfsSrc.
  • Updated NebulaConnectEmbedLogin.tsx to remove commented-out code.
  • Enhanced SingleNetworkSelector and MultiNetworkSelector to accept client prop.
  • Refactored DefaultFactory and CustomFactory to include client.
  • Removed a custom caching function in favor of getChains.
  • Adjusted NebulaLoginPage to handle chainIds from searchParams.
  • Improved ChatBar and EmptyStateChatPageContent with context handling.
  • Streamlined Billing and CreditsItem to take client as a prop.
  • Updated various components to ensure consistent usage of ThirdwebClient.

The following files were skipped due to too many changes: apps/dashboard/src/app/nebula-app/(app)/components/ChatPageContent.tsx, apps/dashboard/src/@/components/blocks/multi-select.tsx, apps/dashboard/src/app/nebula-app/(app)/components/ChatBar.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Apr 22, 2025

Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: 21cc01a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 6:45pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 22, 2025 6:45pm
login ⬜️ Skipped (Inspect) Apr 22, 2025 6:45pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 22, 2025 6:45pm
wallet-ui ⬜️ Skipped (Inspect) Apr 22, 2025 6:45pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 22, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title Update Nebula context selection UI [NEB-180] Update Nebula context selection UI, add wallet switcher Apr 22, 2025
@MananTank MananTank marked this pull request as ready for review April 22, 2025 15:51
@MananTank MananTank requested review from a team as code owners April 22, 2025 15:51
@MananTank MananTank changed the title [NEB-180] Update Nebula context selection UI, add wallet switcher [NEB-180] Update Nebula context selection UI, add wallet switcher Apr 22, 2025
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (c03734a) to head (21cc01a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6814   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56940    56940           
  Branches     3943     3943           
=======================================
  Hits        31420    31420           
  Misses      25424    25424           
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.73 KB (0%) 1.1 s (0%) 200 ms (+200.56% 🔺) 1.3 s
thirdweb (cjs) 138.79 KB (0%) 2.8 s (0%) 307 ms (+86.07% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 102 ms (+1892.67% 🔺) 214 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 47 ms (+2443.39% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 19.41 KB (0%) 389 ms (0%) 69 ms (+475.12% 🔺) 457 ms

Copy link
Contributor

graphite-app bot commented Apr 22, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Apr 22, 2025
)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on enhancing the integration of the `ThirdwebClient` across various components in the application, enabling better management of blockchain interactions and improving the overall architecture for network handling.

### Detailed summary
- Removed `chainId` parameter from `auth-actions.ts`.
- Updated various components to include `client` prop for `ThirdwebClient`.
- Modified `ChainIconClient` to use `src` instead of `ipfsSrc`.
- Integrated `client` in `SingleNetworkSelector`, `MultiNetworkSelector`, and other related components.
- Enhanced `NebulaLoginPage` to handle multiple chains.
- Refactored `EmptyStateChatPageContent` to support wallet management.
- Updated story files to include `client` for testing.
- Removed obsolete code related to chain ID fetching.

> The following files were skipped due to too many changes: `apps/dashboard/src/app/nebula-app/(app)/components/ChatPageContent.tsx`, `apps/dashboard/src/@/components/blocks/multi-select.tsx`, `apps/dashboard/src/app/nebula-app/(app)/components/ChatBar.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 22, 2025 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 22, 2025 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 22, 2025 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 22, 2025 18:23 Inactive
)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on enhancing the integration of the `ThirdwebClient` across various components in the application, enabling better management of blockchain interactions and improving the overall architecture for network handling.

### Detailed summary
- Removed `chainId` parameter from `auth-actions.ts`.
- Updated various components to include `client` prop for `ThirdwebClient`.
- Modified `ChainIconClient` to use `src` instead of `ipfsSrc`.
- Integrated `client` in `SingleNetworkSelector`, `MultiNetworkSelector`, and other related components.
- Enhanced `NebulaLoginPage` to handle multiple chains.
- Refactored `EmptyStateChatPageContent` to support wallet management.
- Updated story files to include `client` for testing.
- Removed obsolete code related to chain ID fetching.

> The following files were skipped due to too many changes: `apps/dashboard/src/app/nebula-app/(app)/components/ChatPageContent.tsx`, `apps/dashboard/src/@/components/blocks/multi-select.tsx`, `apps/dashboard/src/app/nebula-app/(app)/components/ChatBar.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 22, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 22, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 22, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 22, 2025 18:36 Inactive
@graphite-app graphite-app bot merged commit 21cc01a into main Apr 22, 2025
24 checks passed
@graphite-app graphite-app bot deleted the neb-180 branch April 22, 2025 18:48
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 22, 2025 18:48 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 22, 2025 18:48 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 22, 2025 18:48 Inactive
@vercel vercel bot temporarily deployed to Production – login April 22, 2025 18:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants