-
Notifications
You must be signed in to change notification settings - Fork 524
[NEB-180] Update Nebula context selection UI, add wallet switcher #6814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6814 +/- ##
=======================================
Coverage 55.18% 55.18%
=======================================
Files 896 896
Lines 56940 56940
Branches 3943 3943
=======================================
Hits 31420 31420
Misses 25424 25424
Partials 96 96
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on enhancing the integration of the `ThirdwebClient` across various components in the application, enabling better management of blockchain interactions and improving the overall architecture for network handling. ### Detailed summary - Removed `chainId` parameter from `auth-actions.ts`. - Updated various components to include `client` prop for `ThirdwebClient`. - Modified `ChainIconClient` to use `src` instead of `ipfsSrc`. - Integrated `client` in `SingleNetworkSelector`, `MultiNetworkSelector`, and other related components. - Enhanced `NebulaLoginPage` to handle multiple chains. - Refactored `EmptyStateChatPageContent` to support wallet management. - Updated story files to include `client` for testing. - Removed obsolete code related to chain ID fetching. > The following files were skipped due to too many changes: `apps/dashboard/src/app/nebula-app/(app)/components/ChatPageContent.tsx`, `apps/dashboard/src/@/components/blocks/multi-select.tsx`, `apps/dashboard/src/app/nebula-app/(app)/components/ChatBar.tsx` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
aa9575c
to
95aa04a
Compare
) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on enhancing the integration of the `ThirdwebClient` across various components in the application, enabling better management of blockchain interactions and improving the overall architecture for network handling. ### Detailed summary - Removed `chainId` parameter from `auth-actions.ts`. - Updated various components to include `client` prop for `ThirdwebClient`. - Modified `ChainIconClient` to use `src` instead of `ipfsSrc`. - Integrated `client` in `SingleNetworkSelector`, `MultiNetworkSelector`, and other related components. - Enhanced `NebulaLoginPage` to handle multiple chains. - Refactored `EmptyStateChatPageContent` to support wallet management. - Updated story files to include `client` for testing. - Removed obsolete code related to chain ID fetching. > The following files were skipped due to too many changes: `apps/dashboard/src/app/nebula-app/(app)/components/ChatPageContent.tsx`, `apps/dashboard/src/@/components/blocks/multi-select.tsx`, `apps/dashboard/src/app/nebula-app/(app)/components/ChatBar.tsx` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
PR-Codex overview
This PR focuses on integrating
ThirdwebClient
across several components and improving the handling of network and chain data within the application. It also removes some redundant code and refines the structure of several files.Detailed summary
ContextFilters.tsx
andContextFilters.stories.tsx
.auth-actions.ts
to includechainId
in the JSON body.thirdwebClient
to various components for enhanced functionality.ChainIconClient
to utilizesrc
instead ofipfsSrc
.NebulaConnectEmbedLogin.tsx
to remove commented-out code.SingleNetworkSelector
andMultiNetworkSelector
to acceptclient
prop.DefaultFactory
andCustomFactory
to includeclient
.getChains
.NebulaLoginPage
to handlechainIds
fromsearchParams
.ChatBar
andEmptyStateChatPageContent
with context handling.Billing
andCreditsItem
to takeclient
as a prop.ThirdwebClient
.