Skip to content

[SDK] Remove minHeight constraint from TokenSelectorScreen #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 22, 2025


PR-Codex overview

This PR focuses on styling changes in the TokenSelectorScreen.tsx file, specifically adjusting the appearance of a component by modifying its border and minimum height properties.

Detailed summary

  • Updated borderRadius to radius.lg.
  • Changed border to 1px solid ${theme.colors.borderColor}.
  • Set minHeight to "350px".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 9:27pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 9:27pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 9:27pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 9:27pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 9:27pm

Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: 8b2032d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title [UI] Remove minHeight constraint from TokenSelectorScreen [SDK] Remove minHeight constraint from TokenSelectorScreen Apr 22, 2025
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 22, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review April 22, 2025 21:19
@joaquim-verges joaquim-verges requested review from a team as code owners April 22, 2025 21:19
@joaquim-verges joaquim-verges merged commit 72a4ac5 into main Apr 22, 2025
16 of 22 checks passed
@joaquim-verges joaquim-verges deleted the _UI_Remove_minHeight_constraint_from_TokenSelectorScreen branch April 22, 2025 21:19
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.73 KB (0%) 1.1 s (0%) 153 ms (+140.02% 🔺) 1.2 s
thirdweb (cjs) 138.79 KB (0%) 2.8 s (0%) 282 ms (+92.97% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 58 ms (+908.45% 🔺) 170 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 29 ms (+1513.75% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 19.41 KB (0%) 389 ms (0%) 85 ms (+606.98% 🔺) 473 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant