Deprecate pack #6823
Merged
Deprecate pack #6823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ee3495f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
size-limit report 📦
|
joaquim-verges
approved these changes
Apr 23, 2025
kumaryash90
added
the
merge-queue
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6823 +/- ##
=======================================
Coverage 55.18% 55.18%
=======================================
Files 896 896
Lines 56951 56952 +1
Branches 3946 3944 -2
=======================================
+ Hits 31430 31431 +1
Misses 25425 25425
Partials 96 96
🚀 New features to boost your workflow:
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on deprecating the `Pack` contract in the `thirdweb` library due to its incompatibility with the Pectra update. Support for this contract will be removed in the next release.
### Detailed summary
- Added deprecation notice for the `Pack` contract in:
- `packages/thirdweb/src/extensions/pack/createNewPack.ts`
- `packages/thirdweb/src/extensions/prebuilts/deploy-pack.ts`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
yash/deprecate-pack
branch
from
e29b5bf to
ee3495f
Compare
graphite-app
bot
removed
the
merge-queue
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on deprecating the
Packcontract in thethirdwebpackage due to its incompatibility with the Pectra update, indicating that support will be removed in the next release.Detailed summary
Packcontract in:packages/thirdweb/src/extensions/pack/createNewPack.tspackages/thirdweb/src/extensions/prebuilts/deploy-pack.ts