Skip to content

Custom factory addr for Chiliz mainnet #6824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025

Conversation

kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Apr 23, 2025


PR-Codex overview

This PR introduces a custom factory address for the Chiliz mainnet in the thirdweb package and updates the relevant code to include this new address.

Detailed summary

  • Added a custom factory address for Chiliz mainnet: 88888 set to "0xc501b9abf5540de1dd24f66633b1ecf35ff7101f" in packages/thirdweb/src/contract/deployment/utils/create-2-factory.ts.
  • Commented on the enforcement of EIP155 and the reason for hardcoding the address.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners April 23, 2025 10:56
Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: 0b01130

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 0:05am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 23, 2025 0:05am
login ⬜️ Skipped (Inspect) Apr 23, 2025 0:05am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 23, 2025 0:05am
wallet-ui ⬜️ Skipped (Inspect) Apr 23, 2025 0:05am

Copy link
Contributor

graphite-app bot commented Apr 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 23, 2025
Copy link
Contributor

github-actions bot commented Apr 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.92 KB (0%) 1.1 s (0%) 173 ms (+165.37% 🔺) 1.2 s
thirdweb (cjs) 143.74 KB (0%) 2.9 s (0%) 292 ms (+59.33% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 54 ms (+1148.91% 🔺) 167 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 36 ms (+1945.22% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 102 ms (+684.79% 🔺) 488 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 23, 2025 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 23, 2025 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 23, 2025 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 23, 2025 11:58 Inactive
@kumaryash90 kumaryash90 added hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue. labels Apr 23, 2025
Copy link
Member Author

Merge activity

  • Apr 23, 8:25 AM EDT: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@jnsdls jnsdls merged commit b2e56f8 into main Apr 23, 2025
18 of 19 checks passed
@jnsdls jnsdls deleted the yash/custom-factory-addr-for-chiliz branch April 23, 2025 12:36
@joaquim-verges joaquim-verges mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants