Skip to content

Add support for additional languages in Framer rewrites #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 23, 2025

closes: TOOL-4244

Add support for additional languages in Framer rewrites

This PR adds support for additional languages in the Framer rewrite paths. It introduces a new constant FRAMER_ADDITIONAL_LANGUAGES with Spanish ("es") as the initial additional language.

The rewrites configuration has been updated to:

  • Keep the existing English paths
  • Generate additional paths for each language in the format /{lang}{path}
  • Direct these paths to the corresponding landing page URLs

This change enables proper routing for localized landing pages.


PR-Codex overview

This PR focuses on enhancing language support in the next.config.ts file by adding additional languages to the Framer rewrite paths for URLs.

Detailed summary

  • Introduced a constant FRAMER_ADDITIONAL_LANGUAGES with the value ["es"].
  • Updated the Framer path mapping to include additional languages.
  • Used flatMap to create rewrite paths for both the default and additional languages.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 4:23pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 23, 2025 4:23pm
login ⬜️ Skipped (Inspect) Apr 23, 2025 4:23pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 23, 2025 4:23pm
wallet-ui ⬜️ Skipped (Inspect) Apr 23, 2025 4:23pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 23, 2025 15:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 23, 2025 15:54 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 23, 2025 15:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 23, 2025 15:54 Inactive
Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: 525e603

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 23, 2025
Copy link
Member Author

jnsdls commented Apr 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

linear bot commented Apr 23, 2025

@jnsdls jnsdls marked this pull request as ready for review April 23, 2025 15:54
@jnsdls jnsdls requested review from a team as code owners April 23, 2025 15:54
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (4baefa5) to head (525e603).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6828   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56953    56953           
  Branches     3946     3946           
=======================================
  Hits        31429    31429           
  Misses      25428    25428           
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.92 KB (0%) 1.1 s (0%) 165 ms (+121.13% 🔺) 1.2 s
thirdweb (cjs) 143.74 KB (0%) 2.9 s (0%) 274 ms (+44.81% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 68 ms (+1286.58% 🔺) 181 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 35 ms (+2037.45% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 93 ms (+573.82% 🔺) 480 ms

Copy link
Contributor

graphite-app bot commented Apr 23, 2025

Merge activity

closes: TOOL-4244

# Add support for additional languages in Framer rewrites

This PR adds support for additional languages in the Framer rewrite paths. It introduces a new constant `FRAMER_ADDITIONAL_LANGUAGES` with Spanish ("es") as the initial additional language.

The rewrites configuration has been updated to:
- Keep the existing English paths
- Generate additional paths for each language in the format `/{lang}{path}`
- Direct these paths to the corresponding landing page URLs

This change enables proper routing for localized landing pages.
@graphite-app graphite-app bot force-pushed the Add_support_for_additional_languages_in_Framer_rewrites branch from 11f9258 to 525e603 Compare April 23, 2025 16:17
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 23, 2025 16:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 23, 2025 16:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 23, 2025 16:17 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 23, 2025 16:17 Inactive
@graphite-app graphite-app bot merged commit 525e603 into main Apr 23, 2025
23 checks passed
@graphite-app graphite-app bot deleted the Add_support_for_additional_languages_in_Framer_rewrites branch April 23, 2025 16:24
@vercel vercel bot temporarily deployed to Production – docs-v2 April 23, 2025 16:24 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 23, 2025 16:24 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 23, 2025 16:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants