[TOOL-4248] Dashboard: Fix explore category page not showing contract cards #6829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
changed the base branch from
Add_plan_cancellation_and_re-subscription_functionality
to
graphite-base/6829
MananTank
force-pushed
the
graphite-base/6829
branch
from
b722df1 to
4baefa5
Compare
MananTank
force-pushed
the
04-23-dashboard_fix_explore_category_page_not_undefined_client
branch
from
7d9ead3 to
fdce789
Compare
MananTank
added
the
hotfix
Graphite App
MananTank
changed the title
MananTank
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6829 +/- ##
=======================================
Coverage 55.18% 55.18%
=======================================
Files 896 896
Lines 56953 56953
Branches 3946 3946
=======================================
Hits 31429 31429
Misses 25428 25428
Partials 96 96
🚀 New features to boost your workflow:
|
Merge activity
|
… cards (#6829) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `ExploreCategoryPage` component in the `page.tsx` file to utilize a new client obtained from `getThirdwebClient` instead of passing it as a prop. This change simplifies the component's props and enhances its internal logic. ### Detailed summary - Removed the `client` prop from `ExploreCategoryPageProps`. - Introduced `const client = getThirdwebClient(undefined);` to obtain the client internally. - Updated the `client` prop of the `ContractCard` component to use the newly defined `client` variable instead of `props.client`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
04-23-dashboard_fix_explore_category_page_not_undefined_client
branch
from
fdce789 to
fe46e81
Compare
size-limit report 📦
|
graphite-app
bot
deleted the
04-23-dashboard_fix_explore_category_page_not_undefined_client
branch
graphite-app
bot
removed
the
hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating the
ExploreCategoryPagecomponent by removing the dependency on theThirdwebClienttype and instead utilizing agetThirdwebClientfunction to obtain a client instance directly.Detailed summary
client: ThirdwebClient;fromExploreCategoryPageProps.const client = getThirdwebClient(undefined);to retrieve the client.clientprop in theContractCardcomponent to use the newclientvariable.