Skip to content

[NEB-189] Nebula: Minor UI tweaks #6831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

[NEB-189] Nebula: Minor UI tweaks #6831

merged 1 commit into from
Apr 24, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Apr 23, 2025


PR-Codex overview

This PR focuses on updating the wallet management and UI components in the Chatbar, ChatSidebar, FloatingChatContent, and ChatPageContent files. It introduces new wallet identification methods and modifies the UI to enhance the user experience.

Detailed summary

  • Updated connectedWallets to use walletId instead of type.
  • Changed NebulaIcon size in ChatSidebar.
  • Updated badge text from "Beta" to "Alpha" in ChatSidebar.
  • Enhanced Button styling in ChatSidebar.
  • Added useActiveWallet to manage wallet state in FloatingChatContent.
  • Modified handleNebulaPrompt to handle empty responses.
  • Updated WalletMeta type to use walletId.
  • Changed popover width in ChatBar.
  • Wrapped AccountAvatar in AccountProvider in WalletSelector.
  • Adjusted wallet type checks to use walletId in WalletSelector.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Apr 23, 2025

Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 4:07am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 24, 2025 4:07am
login ⬜️ Skipped (Inspect) Apr 24, 2025 4:07am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 24, 2025 4:07am
wallet-ui ⬜️ Skipped (Inspect) Apr 24, 2025 4:07am

Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: 6549381

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 23, 2025 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 23, 2025 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 23, 2025 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 23, 2025 20:22 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 23, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (f912e42) to head (1fd1578).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6831   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56953    56953           
  Branches     3946     3946           
=======================================
  Hits        31429    31429           
  Misses      25428    25428           
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 172 ms (+128.58% 🔺) 1.2 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 299 ms (+55.46% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 50 ms (+916.58% 🔺) 164 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 37 ms (+2530.29% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 93 ms (+639.27% 🔺) 479 ms

@MananTank MananTank marked this pull request as ready for review April 23, 2025 21:13
@MananTank MananTank requested review from a team as code owners April 23, 2025 21:13
Copy link
Contributor

graphite-app bot commented Apr 24, 2025

Merge activity

  • Apr 24, 12:00 AM EDT: MananTank added this pull request to the Graphite merge queue.
  • Apr 24, 4:07 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `Chatbar`, `ChatSidebar`, `FloatingChatContent`, and `ChatPageContent` components to enhance wallet management and user interface elements, including wallet identifiers and visual adjustments.

### Detailed summary
- Updated `connectedWallets` to include `walletId` instead of `type`.
- Changed `NebulaIcon` size in `ChatSidebar` from `size-8` to `size-6`.
- Updated `Badge` text from "Beta" to "Alpha" in `ChatSidebar`.
- Modified `Button` class in `ChatSidebar` to include a background.
- Added `useActiveWallet` hook in `FloatingChatContent`.
- Adjusted wallet handling in `FloatingChatContent` to utilize `activeWallet`.
- Enhanced error messaging in `handleNebulaPrompt` for no response scenarios.
- Updated `WalletMeta` type to use `walletId` instead of `type`.
- Refined `WalletSelector` to include `AccountProvider` and `WalletProvider` components.
- Improved loading and fallback components for account avatars and names.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 04:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 24, 2025 04:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 04:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 04:00 Inactive
@joaquim-verges joaquim-verges merged commit b50b320 into main Apr 24, 2025
19 of 20 checks passed
@joaquim-verges joaquim-verges deleted the neb-189 branch April 24, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants