Skip to content

chore: Add unthreadCustomerId to TeamResponse #6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Apr 24, 2025

PR-Codex overview

This PR focuses on adding the unthreadCustomerId property to the TeamResponse interface and related mock data structures across the codebase.

Detailed summary

  • Added unthreadCustomerId: null to the mock data in apps/dashboard/src/stories/stubs.ts.
  • Updated validTeamAndProjectResponse in packages/service-utils/src/mocks.ts to include unthreadCustomerId.
  • Introduced unthreadCustomerId: string | null in the TeamResponse interface in packages/service-utils/src/core/api.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 11:25am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 11:25am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 11:25am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 11:25am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 11:25am

@arcoraven arcoraven requested a review from a team as a code owner April 24, 2025 10:22
Copy link

changeset-bot bot commented Apr 24, 2025

🦋 Changeset detected

Latest commit: d95b3d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

graphite-app bot commented Apr 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.30%. Comparing base (9cf5ba8) to head (d95b3d3).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6837      +/-   ##
==========================================
+ Coverage   55.23%   55.30%   +0.06%     
==========================================
  Files         896      896              
  Lines       57020    57023       +3     
  Branches     3955     3968      +13     
==========================================
+ Hits        31497    31536      +39     
+ Misses      25427    25390      -37     
- Partials       96       97       +1     
Flag Coverage Δ
packages 55.30% <ø> (+0.06%) ⬆️

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but has to also be added to stories mocks. (Check failing vercel build for details.)

@arcoraven arcoraven requested a review from a team as a code owner April 24, 2025 11:07
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 24, 2025
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 11:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 11:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 24, 2025 11:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 11:07 Inactive
Copy link
Contributor

github-actions bot commented Apr 24, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 408 ms (+18.89% 🔺) 1.5 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 1.2 s (+20.12% 🔺) 4 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 23 ms (-12.59% 🔽) 136 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 48 ms (+570.9% 🔺) 58 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 90 ms (+64.02% 🔺) 477 ms

@arcoraven arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Apr 24, 2025
Copy link
Contributor Author

arcoraven commented Apr 24, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on adding a new property, `unthreadCustomerId`, to the `TeamResponse` structure across various files, enhancing the data model for teams in the application.

### Detailed summary
- Added `unthreadCustomerId: null` to the `TeamResponse` in `apps/dashboard/src/stories/stubs.ts`.
- Updated `validTeamAndProjectResponse` to include `unthreadCustomerId` in `packages/service-utils/src/mocks.ts`.
- Defined `unthreadCustomerId: string | null` in the `TeamResponse` interface in `packages/service-utils/src/core/api.ts`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants