Skip to content

Nebula: Use Nebula project keys #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Apr 24, 2025


PR-Codex overview

This PR focuses on updating the environment variables and refactoring the nebulaThirdwebClient to nebulaAppThirdwebClient, ensuring the application uses the correct secret keys and client IDs for the Nebula app.

Detailed summary

  • Added new environment variables: NEXT_PUBLIC_NEBULA_APP_CLIENT_ID and NEBULA_APP_SECRET_KEY.
  • Replaced nebulaThirdwebClient with nebulaAppThirdwebClient in components.
  • Updated secret key usage in getNebulaLoginPayload and doNebulaLogin functions.
  • Refactored getThirdwebClient to use new environment variables and set thirdweb domains.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 4:15pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 24, 2025 4:15pm
login ⬜️ Skipped (Inspect) Apr 24, 2025 4:15pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 24, 2025 4:15pm
wallet-ui ⬜️ Skipped (Inspect) Apr 24, 2025 4:15pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 24, 2025 15:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 15:54 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 15:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 15:54 Inactive
Copy link

changeset-bot bot commented Apr 24, 2025

⚠️ No Changeset found

Latest commit: 1d598ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 24, 2025
@MananTank MananTank marked this pull request as ready for review April 24, 2025 15:54
@MananTank MananTank requested review from a team as code owners April 24, 2025 15:54
Copy link
Member Author

MananTank commented Apr 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.30%. Comparing base (f157e34) to head (1d598ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6839   +/-   ##
=======================================
  Coverage   55.30%   55.30%           
=======================================
  Files         896      896           
  Lines       57023    57023           
  Branches     3968     3968           
=======================================
  Hits        31536    31536           
  Misses      25390    25390           
  Partials       97       97           
Flag Coverage Δ
packages 55.30% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 24, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 215 ms (+216.98% 🔺) 1.3 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 367 ms (+101.4% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 55 ms (+824.19% 🔺) 168 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 23 ms (+1404.51% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 113 ms (+881.78% 🔺) 499 ms

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM make sure the env vars are set for both preview & prod

Copy link
Contributor

graphite-app bot commented Apr 24, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the authentication and client configuration for the `Nebula` application by replacing the usage of the `DASHBOARD_THIRDWEB_SECRET_KEY` with `NEBULA_APP_SECRET_KEY`, and modifying the thirdweb client setup.

### Detailed summary
- Added `NEXT_PUBLIC_NEBULA_APP_CLIENT_ID` and `NEBULA_APP_SECRET_KEY` to `env.ts`.
- Replaced `nebulaThirdwebClient` with `nebulaAppThirdwebClient` in `EmptyStateChatPageContent.tsx`.
- Updated headers in `auth-actions.ts` to use `NEBULA_APP_SECRET_KEY`.
- Refactored `nebulaThirdwebClient.ts` to create a new client using `NEBULA_APP_SECRET_KEY` and `NEXT_PUBLIC_NEBULA_APP_CLIENT_ID`.
- Updated `NebulaConnectWallet` component to use `nebulaAppThirdwebClient`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-24-nebula_use_nebula_project_keys branch from 329ce9e to 1d598ce Compare April 24, 2025 16:08
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 16:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 24, 2025 16:08 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 16:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 16:08 Inactive
@graphite-app graphite-app bot merged commit 1d598ce into main Apr 24, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 04-24-nebula_use_nebula_project_keys branch April 24, 2025 16:16
@vercel vercel bot temporarily deployed to Production – wallet-ui April 24, 2025 16:16 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 24, 2025 16:16 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 24, 2025 16:16 Inactive
@vercel vercel bot temporarily deployed to Production – login April 24, 2025 16:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants