-
Notifications
You must be signed in to change notification settings - Fork 524
Nebula: Use Nebula project keys #6839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6839 +/- ##
=======================================
Coverage 55.30% 55.30%
=======================================
Files 896 896
Lines 57023 57023
Branches 3968 3968
=======================================
Hits 31536 31536
Misses 25390 25390
Partials 97 97
🚀 New features to boost your workflow:
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM make sure the env vars are set for both preview & prod
Merge activity
|
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the authentication and client configuration for the `Nebula` application by replacing the usage of the `DASHBOARD_THIRDWEB_SECRET_KEY` with `NEBULA_APP_SECRET_KEY`, and modifying the thirdweb client setup. ### Detailed summary - Added `NEXT_PUBLIC_NEBULA_APP_CLIENT_ID` and `NEBULA_APP_SECRET_KEY` to `env.ts`. - Replaced `nebulaThirdwebClient` with `nebulaAppThirdwebClient` in `EmptyStateChatPageContent.tsx`. - Updated headers in `auth-actions.ts` to use `NEBULA_APP_SECRET_KEY`. - Refactored `nebulaThirdwebClient.ts` to create a new client using `NEBULA_APP_SECRET_KEY` and `NEXT_PUBLIC_NEBULA_APP_CLIENT_ID`. - Updated `NebulaConnectWallet` component to use `nebulaAppThirdwebClient`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
329ce9e
to
1d598ce
Compare
PR-Codex overview
This PR focuses on updating the environment variables and refactoring the
nebulaThirdwebClient
tonebulaAppThirdwebClient
, ensuring the application uses the correct secret keys and client IDs for the Nebula app.Detailed summary
NEXT_PUBLIC_NEBULA_APP_CLIENT_ID
andNEBULA_APP_SECRET_KEY
.nebulaThirdwebClient
withnebulaAppThirdwebClient
in components.getNebulaLoginPayload
anddoNebulaLogin
functions.getThirdwebClient
to use new environment variables and set thirdweb domains.