Skip to content

[Portal] removed glossary, added new articles, deprecated old pages #6841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

saminacodes
Copy link
Member

@saminacodes saminacodes commented Apr 24, 2025

CORE-0000


PR-Codex overview

This PR focuses on the removal of various glossary-related files and the addition of new features in the sidebar navigation across different components, including updates to redirect paths and the introduction of new content in the page.mdx files.

Detailed summary

  • Deleted multiple glossary files in apps/portal/src/app/glossary/.
  • Updated sidebar navigation in apps/portal/src/app/account/sidebar.tsx, renaming "API Keys" to "Projects" and adding "Transfer Projects".
  • Added new sidebar item "Playground" in apps/portal/src/app/engine/sidebar.tsx.
  • Introduced new content and steps in apps/portal/src/app/account/api-keys/transfer-projects/page.mdx.
  • Added fee-related explanations in apps/portal/src/app/connect/pay/fees/page.mdx.
  • Added glossaryRedirects for various glossary terms in apps/portal/redirects.mjs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners April 24, 2025 16:56
Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 5:19pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Apr 24, 2025 5:19pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 24, 2025 5:19pm
thirdweb-www ⬜️ Skipped (Inspect) Apr 24, 2025 5:19pm
wallet-ui ⬜️ Skipped (Inspect) Apr 24, 2025 5:19pm

Copy link

changeset-bot bot commented Apr 24, 2025

⚠️ No Changeset found

Latest commit: dc07fdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented Apr 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Apr 24, 2025
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 24, 2025 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 24, 2025 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 16:58 Inactive
@saminacodes saminacodes requested a review from gregfromstl April 24, 2025 17:00
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.30%. Comparing base (1d598ce) to head (dc07fdd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6841   +/-   ##
=======================================
  Coverage   55.30%   55.30%           
=======================================
  Files         896      896           
  Lines       57023    57023           
  Branches     3968     3968           
=======================================
  Hits        31536    31536           
  Misses      25390    25390           
  Partials       97       97           
Flag Coverage Δ
packages 55.30% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 24, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 24, 2025 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 24, 2025 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 17:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 24, 2025 17:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 17:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 17:07 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Apr 24, 2025
Copy link
Member

gregfromstl commented Apr 24, 2025

Merge activity

Copy link
Contributor

github-actions bot commented Apr 24, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 192 ms (+195.21% 🔺) 1.3 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 287 ms (+55.62% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 66 ms (+1329.92% 🔺) 180 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 16 ms (+700.35% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 68 ms (+359.22% 🔺) 455 ms

…6841)

CORE-0000

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on the removal of various glossary-related files and the addition of new features and content in the sidebar navigation for different sections of the application.

### Detailed summary
- Deleted multiple `.mdx` files related to the glossary in `apps/portal/src/app/glossary/`.
- Updated sidebar navigation in `apps/portal/src/app/account/sidebar.tsx` to rename "API Keys" to "Projects" and added "Transfer Projects".
- Added new sidebar entry "Playground" in `apps/portal/src/app/engine/sidebar.tsx`.
- Enhanced `apps/portal/src/app/account/api-keys/transfer-projects/page.mdx` with steps for transferring projects, including images.
- Improved `apps/portal/src/app/connect/pay/fees/page.mdx` with detailed explanations of fees.
- Introduced `glossaryRedirects` in `apps/portal/redirects.mjs` for various glossary pages.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 24, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 17:14 Inactive
@graphite-app graphite-app bot merged commit dc07fdd into main Apr 24, 2025
23 checks passed
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Apr 24, 2025
@graphite-app graphite-app bot deleted the portal-edits branch April 24, 2025 17:20
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 24, 2025 17:20 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 24, 2025 17:20 Inactive
@vercel vercel bot temporarily deployed to Production – login April 24, 2025 17:20 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www April 24, 2025 17:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants