-
Notifications
You must be signed in to change notification settings - Fork 524
SDK: Signature screen loading state improvements #6849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK: Signature screen loading state improvements #6849
Conversation
🦋 Changeset detectedLatest commit: fd83572 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
PR-Codex overview
This PR focuses on improving the loading state management in the
thirdweb
package, specifically in the authentication process using theuseSiweAuth
hook and theSignatureScreen
.Detailed summary
isPending
to the state returned byuseSiweAuth
.SignatureScreen
to check forsiweAuth.isPending
instead ofsiweAuth.isLoading
.ConnectButton
to usesiweAuth.isPending
instead ofsiweAuth.isLoading
.