Skip to content

Add domain verification functionality for teams #6850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 24, 2025

Domain Verification for Teams

This PR adds domain verification functionality for teams, allowing team owners to verify domain ownership through DNS TXT records.

Features

  • Added server-side API functions to check and create domain verifications
  • Created a new domain verification settings card component for the team settings page
  • Added verification status display in team headers with a verified badge
  • Implemented automatic status checking for pending verifications

Implementation Details

  • The verification process uses DNS TXT records for domain ownership validation
  • Verification states include "pending" and "verified" with appropriate UI for each
  • Added error handling for invalid domains and already verified domains
  • Automatic polling checks verification status every 10 seconds when pending

The feature enhances team identity by allowing teams to prove domain ownership, which will enable additional features in the future.


PR-Codex overview

This PR focuses on adding domain verification functionality to the team settings, allowing teams to verify their domains and display verification status within the app.

Detailed summary

  • Added verifiedDomain fields in various types and components.
  • Introduced TeamVerifiedIcon to show verification status.
  • Enhanced TeamGeneralSettingsPage to accept initialVerification and isOwnerAccount.
  • Implemented domain verification logic in TeamDomainVerificationCard.
  • Created API functions for checking and creating domain verification.
  • Updated UI components to reflect domain verification status and provide user feedback.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 11:13pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 24, 2025 11:13pm
login ⬜️ Skipped (Inspect) Apr 24, 2025 11:13pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 24, 2025 11:13pm
wallet-ui ⬜️ Skipped (Inspect) Apr 24, 2025 11:13pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 22:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 22:30 Inactive
Copy link

changeset-bot bot commented Apr 24, 2025

⚠️ No Changeset found

Latest commit: 759758f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 22:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 24, 2025 22:30 Inactive
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Apr 24, 2025
Copy link
Member Author

jnsdls commented Apr 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review April 24, 2025 22:31
@jnsdls jnsdls requested review from a team as code owners April 24, 2025 22:31
Copy link
Contributor

github-actions bot commented Apr 24, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 129 ms (+90.48% 🔺) 1.2 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 262 ms (+45.73% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 47 ms (+886.42% 🔺) 161 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 31 ms (+2181.69% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 60 ms (+530.12% 🔺) 447 ms

@jnsdls jnsdls force-pushed the Add_domain_verification_functionality_for_teams branch from ea755f1 to 759758f Compare April 24, 2025 23:07
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 24, 2025 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 23:07 Inactive
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (31e87b0) to head (759758f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6850   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         896      896           
  Lines       57023    57023           
  Branches     3971     3967    -4     
=======================================
  Hits        31541    31541           
  Misses      25385    25385           
  Partials       97       97           
Flag Coverage Δ
packages 55.31% <ø> (ø)

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jnsdls jnsdls merged commit 473c9cc into main Apr 24, 2025
24 checks passed
@jnsdls jnsdls deleted the Add_domain_verification_functionality_for_teams branch April 24, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants