Skip to content

[NEB-215] Update transaction confirmation prompt #6861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Apr 25, 2025


PR-Codex overview

This PR updates the Chats component by modifying the message sent upon transaction settlement. It replaces a hardcoded message with a new function, getTransactionSettledPrompt, which provides a more detailed and contextual response.

Detailed summary

  • Updated the onTxSettled callback to use getTransactionSettledPrompt(txHash) instead of a hardcoded string.
  • Introduced the getTransactionSettledPrompt function to generate a more informative message regarding the transaction settlement.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Apr 25, 2025

Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 7:50pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 25, 2025 7:50pm
login ⬜️ Skipped (Inspect) Apr 25, 2025 7:50pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 25, 2025 7:50pm
wallet-ui ⬜️ Skipped (Inspect) Apr 25, 2025 7:50pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 16:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 16:48 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 16:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 16:48 Inactive
Copy link

changeset-bot bot commented Apr 25, 2025

⚠️ No Changeset found

Latest commit: 2d27c4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author

MananTank commented Apr 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review April 25, 2025 16:49
@MananTank MananTank requested review from a team as code owners April 25, 2025 16:49
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (72628ef) to head (2d27c4f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6861   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         896      896           
  Lines       57024    57024           
  Branches     3968     3968           
=======================================
  Hits        31542    31542           
  Misses      25385    25385           
  Partials       97       97           
Flag Coverage Δ
packages 55.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 25, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 272 ms (+205.72% 🔺) 1.3 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 501 ms (+76.26% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 97 ms (+1349.03% 🔺) 210 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 48 ms (+797.95% 🔺) 58 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 49 ms (+172.76% 🔺) 436 ms

Copy link
Contributor

graphite-app bot commented Apr 25, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the transaction message in the `Chats` component to use a new function for generating the prompt, enhancing clarity and consistency in user communication.

### Detailed summary
- Replaced the inline message in `onTxSettled` with a call to `getTransactionSettledPrompt`.
- Added the `getTransactionSettledPrompt` function, which formats a detailed success message for a settled transaction.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Base automatically changed from neb-191 to main April 25, 2025 19:50
@graphite-app graphite-app bot merged commit 2d27c4f into main Apr 25, 2025
21 checks passed
@graphite-app graphite-app bot deleted the neb-215 branch April 25, 2025 19:51
@vercel vercel bot temporarily deployed to Production – docs-v2 April 25, 2025 19:51 Inactive
@vercel vercel bot temporarily deployed to Production – login April 25, 2025 19:51 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 25, 2025 19:51 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 25, 2025 19:51 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www April 25, 2025 20:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants