-
Notifications
You must be signed in to change notification settings - Fork 526
[NEB-215] Update transaction confirmation prompt #6861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6861 +/- ##
=======================================
Coverage 55.31% 55.31%
=======================================
Files 896 896
Lines 57024 57024
Branches 3968 3968
=======================================
Hits 31542 31542
Misses 25385 25385
Partials 97 97
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the transaction message in the `Chats` component to use a new function for generating the prompt, enhancing clarity and consistency in user communication. ### Detailed summary - Replaced the inline message in `onTxSettled` with a call to `getTransactionSettledPrompt`. - Added the `getTransactionSettledPrompt` function, which formats a detailed success message for a settled transaction. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
8f166ff
to
72628ef
Compare
f530be0
to
2d27c4f
Compare
PR-Codex overview
This PR updates the
Chats
component by modifying the message sent upon transaction settlement. It replaces a hardcoded message with a new function,getTransactionSettledPrompt
, which provides a more detailed and contextual response.Detailed summary
onTxSettled
callback to usegetTransactionSettledPrompt(txHash)
instead of a hardcoded string.getTransactionSettledPrompt
function to generate a more informative message regarding the transaction settlement.