Skip to content

Dashboard: Fix team invite UI not showing feedback on submit #6866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Apr 25, 2025


PR-Codex overview

This PR focuses on refactoring the InviteSection component in the InviteSection.tsx file. It improves the handling of form updates and adds a reset button for the form.

Detailed summary

  • Removed the useEffect hook for resetting mutation results.
  • Added an onChange handler to the form that resets the mutation result when form updates occur.
  • Introduced a new Reset button to reset the form and mutation state.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 10:02pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 25, 2025 10:02pm
login ⬜️ Skipped (Inspect) Apr 25, 2025 10:02pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 25, 2025 10:02pm
wallet-ui ⬜️ Skipped (Inspect) Apr 25, 2025 10:02pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 21:41 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 21:41 Inactive
Copy link

changeset-bot bot commented Apr 25, 2025

⚠️ No Changeset found

Latest commit: 692c25e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 21:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 21:41 Inactive
@MananTank MananTank marked this pull request as ready for review April 25, 2025 21:41
@MananTank MananTank requested review from a team as code owners April 25, 2025 21:41
Copy link
Member Author

MananTank commented Apr 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 25, 2025
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (d568f8f) to head (692c25e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6866   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         896      896           
  Lines       57024    57024           
  Branches     3968     3968           
=======================================
  Hits        31542    31542           
  Misses      25385    25385           
  Partials       97       97           
Flag Coverage Δ
packages 55.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank force-pushed the 04-26-dashboard_fix_team_invite_ui_not_showing_feedback_on_submit branch from 2b39c5d to a45e91d Compare April 25, 2025 21:45
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 21:45 Inactive
Copy link
Contributor

github-actions bot commented Apr 25, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 1.8 s (+11.5% 🔺) 2.8 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 4.5 s (-5.37% 🔽) 7.4 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 147 ms (+35.56% 🔺) 260 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 44 ms (-19.42% 🔽) 54 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 486 ms (+52.9% 🔺) 873 ms

Copy link
Contributor

graphite-app bot commented Apr 25, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the `InviteSection` component by modifying the form handling logic and enhancing the user interface with additional functionality.

### Detailed summary
- Removed the `useEffect` hook that reset the mutation result on form updates.
- Changed the form's `onChange` to reset the mutation result if `sendInvites.data` exists.
- Updated the button layout to include a `Reset` button for clearing the form and resetting invites.
- Adjusted class names for better spacing and alignment.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-26-dashboard_fix_team_invite_ui_not_showing_feedback_on_submit branch from a45e91d to 692c25e Compare April 25, 2025 21:55
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 21:55 Inactive
@graphite-app graphite-app bot merged commit 692c25e into main Apr 25, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 04-26-dashboard_fix_team_invite_ui_not_showing_feedback_on_submit branch April 25, 2025 22:03
@vercel vercel bot temporarily deployed to Production – login April 25, 2025 22:03 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 25, 2025 22:03 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 25, 2025 22:03 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 25, 2025 22:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants