Skip to content

[Portal] Fix HTTP method in wallet users API example from POST to GET #6868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 26, 2025


PR-Codex overview

This PR updates the documentation for fetching user details from the in-app wallet API. It introduces new sections, examples, and clarifications on how to retrieve user information and the response format.

Detailed summary

  • Changed the title from Get Users to Fetch a Single User.
  • Added detailed instructions for fetching user details via a GET request.
  • Included query parameters and their descriptions.
  • Explained authentication requirements.
  • Provided example curl commands for different query scenarios.
  • Introduced the getUser method for SDK users.
  • Updated the method to fetch all users from POST to GET.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2025 9:17am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Apr 26, 2025 9:17am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 26, 2025 9:17am
thirdweb-www ⬜️ Skipped (Inspect) Apr 26, 2025 9:17am
wallet-ui ⬜️ Skipped (Inspect) Apr 26, 2025 9:17am

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 26, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 26, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 26, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 26, 2025 07:39 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Apr 26, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review April 26, 2025 07:39
@joaquim-verges joaquim-verges requested review from a team as code owners April 26, 2025 07:39
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (dbb7824) to head (d43ad17).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6868   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         896      896           
  Lines       57024    57024           
  Branches     3968     3968           
=======================================
  Hits        31542    31542           
  Misses      25385    25385           
  Partials       97       97           
Flag Coverage Δ
packages 55.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

changeset-bot bot commented Apr 26, 2025

⚠️ No Changeset found

Latest commit: d43ad17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 26, 2025 07:41 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 26, 2025 07:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 26, 2025 07:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 26, 2025 07:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 26, 2025 07:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 26, 2025 07:42 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 26, 2025 07:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 26, 2025 07:42 Inactive
Copy link
Contributor

github-actions bot commented Apr 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 81 ms (+131.55% 🔺) 1.2 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 161 ms (+76.3% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 28 ms (+1156.23% 🔺) 141 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 10 ms (+1109.68% 🔺) 21 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 45 ms (+637.67% 🔺) 431 ms

@joaquim-verges joaquim-verges force-pushed the _Portal_Fix_HTTP_method_in_wallet_users_API_example_from_POST_to_GET branch from 9571fa7 to 98e29b9 Compare April 26, 2025 09:01
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 26, 2025 09:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 26, 2025 09:01 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 26, 2025 09:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 26, 2025 09:01 Inactive
Copy link
Contributor

graphite-app bot commented Apr 26, 2025

Merge activity

…#6868)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the documentation for fetching user details from the in-app wallet API, providing clearer instructions, examples, and a new method for retrieving user data.

### Detailed summary
- Changed the title from `Get Users` to `Fetch a Single User`.
- Added detailed instructions for fetching user details via a `GET` request.
- Specified query parameters and their descriptions.
- Included authentication requirements.
- Provided example `curl` commands for fetching user details by email and wallet address.
- Described the response format for the API.
- Introduced convenience methods using the `getUser` method from the thirdweb SDK.
- Updated the command for fetching all users from `POST` to `GET`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the _Portal_Fix_HTTP_method_in_wallet_users_API_example_from_POST_to_GET branch from 98e29b9 to d43ad17 Compare April 26, 2025 09:15
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 26, 2025 09:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 26, 2025 09:15 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 26, 2025 09:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 26, 2025 09:15 Inactive
@graphite-app graphite-app bot merged commit d43ad17 into main Apr 26, 2025
22 checks passed
@graphite-app graphite-app bot deleted the _Portal_Fix_HTTP_method_in_wallet_users_API_example_from_POST_to_GET branch April 26, 2025 09:18
@vercel vercel bot temporarily deployed to Production – login April 26, 2025 09:18 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 26, 2025 09:18 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 26, 2025 09:18 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www April 26, 2025 09:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants