update to ruby 2.6.3 #49
Conversation
|
I've updated master to fix the build. If you rebase, your branch should run. |
| @@ -1,6 +1,6 @@ | |||
| Gem::Specification.new do |s| | |||
| s.name = 'descriptive_statistics' | |||
| s.version = '2.5.1' | |||
| s.version = '2.5.2' | |||
There was a problem hiding this comment.
I'm only seeing development changes, not changes to the code of the gem itself, and so no version bump in warranted.
There was a problem hiding this comment.
ok, usually I do that in the patch to track any changes like updates and stuff so people can reference the new version or hold to the last they had running to avoid unwanted gem update at all. but if you prefer I can roll back the version.
| end | ||
| end | ||
|
|
||
| def test_percentile_rank | ||
| @data.each do |test_case| | ||
| assert_equal test_case[0,10].percentile_rank(50).round(6), test_case[26].round(6) | ||
| assert_equal test_case[0, 10].percentile_rank(50).round(6), test_case[26].round(6) |
There was a problem hiding this comment.
I would love to see rubocop implemented in this repository. Would you be open to moving any style related changes to a new pull request, one which included the rubocop package and a configuration?
There was a problem hiding this comment.
Sure, I will do that.
Any preference on the rubocop style guide or just the default one, one thing I would suggest is to increase the line size from 80 columns to something bigger specially for the test parts.
There was a problem hiding this comment.
Hey, I opened the Rubocop PR as you asked, after merge we can work in the style changes 👓
Hi I updated the gems and made some rubocop linters changes on some files.
rake safe running 100%