fix: update version to 11.0.3 and adjust color handling for OemSatellite#1259
fix: update version to 11.0.3 and adjust color handling for OemSatellite#1259
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the application version to 11.0.3 and modifies color handling for OemSatellite objects to use configurable colors instead of hardcoded values.
- Version bumped from 11.0.1/11.0.2 to 11.0.3 across multiple files
- OemSatellite now has configurable
dotColorandorbitColorproperties - Color schemes updated to use OemSatellite's
dotColorinstead of hardcoded orange
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/settings/version.js | Updated VERSION constant to 11.0.3 |
| src/plugins-pro | Updated subproject commit reference |
| src/engine/rendering/color-schemes/object-type-color-scheme.ts | Changed to use OemSatellite's dotColor property, reorganized imports |
| src/engine/rendering/color-schemes/celestrak-color-scheme.ts | Changed to use OemSatellite's dotColor property |
| src/app/rendering/orbit-manager.ts | Added logic to use OemSatellite's dotColor for hover state |
| src/app/objects/oem-satellite.ts | Added orbitColor and dotColor properties with default values |
| package.json | Updated version to 11.0.3 |
| README.md | Updated version badge to 11.0.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| moonPositionCache_: { [key: number]: { position: { x: number; y: number; z: number } } } = {}; | ||
|
|
||
| orbitColor: vec4 = LineColors.GREEN; | ||
| dotColor: rgbaArray = [0, 255, 0, 1]; |
There was a problem hiding this comment.
The dotColor values appear to be in 0-255 range, but rgbaArray is typically expected to be normalized floats between 0.0-1.0 based on the removed hardcoded value [1.0, 0.5, 0.0, 1.0]. This should be [0.0, 1.0, 0.0, 1.0] to match the expected format.
| dotColor: rgbaArray = [0, 255, 0, 1]; | |
| dotColor: rgbaArray = [0.0, 1.0, 0.0, 1.0]; |
|
No description provided.