Skip to content

Add choices filters #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add choices filters #3

wants to merge 3 commits into from

Conversation

1vank1n
Copy link

@1vank1n 1vank1n commented Apr 2, 2021

Hi @thomst!

Thanks for your app. I offer add two classes for choices. Main difference with MultiSelectFilter that in filter correct display name, not value.

@1vank1n
Copy link
Author

1vank1n commented May 7, 2021

add support Django 3.2

@thomst
Copy link
Owner

thomst commented May 28, 2021

Hi @1vank1n
Thanks a lot for your contribution. Your filter classes seems to work well and are a good enhancement. But there are several problems with your pull request:

  • The tests doesn't work with django-3.2. So we cannot simply add django-3.2 support without addressing the issues of failing tests.
  • You didn't add any tests for the new filter classes which leads to a decreasing coverage of ~17%.

So would you either remove the django-3.2 support in your pull request or fix the tests and if neccessary the code for django-3.2?
And do you have the ressources to add some tests for your filter classes? It might be done in a similar way as the tests for the existing ones.

Again. Thanks a lot.

@1vank1n
Copy link
Author

1vank1n commented May 28, 2021

Hi @thomst!

I'll add tests in couple days.

@1oglop1
Copy link

1oglop1 commented Sep 7, 2021

I tried this and It did not display anything for added filters. Django 3.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants