Migrate timeout state to Angular component#454
Migrate timeout state to Angular component#454WaelAlahamdi wants to merge 1 commit intothoth-tech:10.0.xfrom
Conversation
|
I tested this locally with the Doubtfire development container. Both |
millyamolo
left a comment
There was a problem hiding this comment.
I reviewed the timeout migration changes in this PR and the implementation looks consistent with the stated goal of moving timeout handling from legacy AngularJS/CoffeeScript into the Angular code path. The new TimeoutComponent is introduced and wired into the Angular module, and the timeout route is now registered in the Angular state definitions. At the same time, the old timeout state wiring has been removed from the legacy module/state files, and the old CoffeeScript timeout implementation has been deleted, which keeps the migration clean and avoids duplicate ownership.
I also checked the template move (timeout.tpl.html to timeout.component.html) and it appears to be a straightforward rename without unexpected content changes. Structurally, the diff is focused and coherent. New Angular component/state added, old AngularJS timeout references removed, and no unrelated refactors mixed into the same change.
From local testing, the app builds and runs on the PR branch. When navigating to http://localhost:4200/#/timeout?dest¶ms, I observed redirect-to-login behavior when unauthenticated, which seems aligned with route/auth-guard expectations. From my side its working correctly
Thirus224849242
left a comment
There was a problem hiding this comment.
Tested locally by checking out the branch and navigating to http://localhost:4200/#/timeout?dest¶ms. The timeout page loads correctly and redirects to the sign-in page when unauthenticated. No console errors observed. The migration from the legacy AngularJS/CoffeeScript implementation to the Angular component looks clean. Approving.
|
I ran the branch locally with npm run start and tested the timeout flow.
The migration is clean, scoped to the intended files, and removes the legacy CoffeeScript implementation as described. |
officialid130-13e13
left a comment
There was a problem hiding this comment.
Tested on Chrome and Safari. Works as expected. Approving the changes.
Description
This pull request migrates the timeout state from the legacy AngularJS/CoffeeScript implementation to an Angular component and removes the old timeout state wiring. This keeps the existing timeout functionality aligned with the current Angular-based structure used in the project. The legacy AngularJS timeout implementation is no longer used, and the migrated Angular timeout component was verified through local testing.
The change includes:
TimeoutComponenttimeout.tpl.htmltotimeout.component.htmldoubtfire.states.tsTimeoutComponentindoubtfire-angular.module.tsdoubtfire-angularjs.module.tssrc/app/errors/states/states.coffeetimeout.coffeefileFixes # (issue)
Type of change
How Has This Been Tested?
Test steps:
http://localhost:4200/#/timeout?dest¶msTesting Checklist:
Checklist: