Added Catch helper scripts and CMakePresets for CTest integration#106
Merged
macite merged 9 commits intothoth-tech:t1-2025from Jun 20, 2025
Merged
Added Catch helper scripts and CMakePresets for CTest integration#106macite merged 9 commits intothoth-tech:t1-2025from
macite merged 9 commits intothoth-tech:t1-2025from
Conversation
12 tasks
JPF2209
approved these changes
May 21, 2025
JPF2209
left a comment
There was a problem hiding this comment.
I looked at the code and I have no suggestions for it, I approve of it
General Information
- Type of Change:
- Bug fix
- Documentation update
Code Quality
- Repository: Is this Pull Request is made to the correct repository? (Thoth-Tech NOT SplashKit)
- Readability: Is the code easy to read and follow? If not are there comments to help understand
the code? - Maintainability: Can this code be easily maintained or extended in the future?
Functionality
- Correctness: Does the code meet the requirements of the task?
- Impact on Existing Functionality: Has the impact on existing functionality been considered and
tested?
This has been tested by running projects/cmake, then cmake . before make. Once I did this, I then ran both sktests and skunit_tests and these all worked.
Testing
- Test Coverage: Are unit tests provided for new or modified code?
- Test Results: Have all tests passed?
Documentation
- Documentation: Are both inline and applicable external documentation updated and clear?
Pull Request Details
- PR Description: Is the problem being solved clearly described?
- Checklist Completion: Have all relevant checklist items been reviewed and completed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is part of improving unit testing workflow.
Two additional CMake scripts are from the Catch2 2.x repo, used to register Catch2 tests with CTest, which is recommended per the Catch2 tutorial. CMakeLists.txt has been updated to integrate this.
CMake presets have been added to make it easier to build the unit tests from inside VS Code. In the future, presets could be added for building the project with code coverage.
Still needs testing on Mac.Type of change
How Has This Been Tested?
Built test project on WSL and Windows (MSYS2/Mingw64)
Checklist