Add methods to Window class (C#)#108
Merged
omckeon merged 12 commits intothoth-tech:t1-2025from Jun 18, 2025
Merged
Conversation
dijidiji
approved these changes
May 14, 2025
There was a problem hiding this comment.
No suggestions, approved.
How has this been tested?
- Copy api.json to local splaskit.io-starlight
- npm run build
- npm run preview
Confirmed that api.json has methods for the following and that they show up on the site in local testing:
- RandomWindowPoint
- CurrentClip
- PopClip
- PushClip
- ResetClip
- SetClip
- OptionDrawTo
- TakeScreenshot
- GetPixelFromWindow
- FillQuadOnWindow
- EndReadingText
- ReadingText
- StartReadingText
- TextEntryCancelled
- TextInput
Confirmed that the methods were generated for the following in SplashKit.cs:
- RandomWindowPoint
- CurrentClip
- PopClip
- PushClip
- ResetClip
- SetClip
- OptionDrawTo
- TakeScreenshot
- GetPixelFromWindow
- FillQuadOnWindow
- EndReadingText
- ReadingText
- StartReadingText
- TextEntryCancelled
- TextInput
Oliver-Quail
approved these changes
May 20, 2025
Oliver-Quail
left a comment
There was a problem hiding this comment.
Hi @sam-stajnko,
I have read over your code and the previous review. I have no suggestions for improvements. I approve this PR
omckeon
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
The Window class in the generated C# file is missing some methods. Therefore, the header files containing the relevant function declarations need to be updated so that the translator can generate the missing methods.
Fixes
Missing attributes were added to the header docs for the following functions that are currently missing from the Window class:
The translator was then ran to generate the api.json and SplashKit.cs files.
Type of change
How Has This Been Tested?
(Both of the above files are located in the generated folder)
Testing Checklist
Checklist