Create Python PIP Package#65
Merged
omckeon merged 3 commits intothoth-tech:python-pip-packagefrom Jul 4, 2025
Merged
Conversation
hugglesfox
suggested changes
Aug 30, 2024
There was a problem hiding this comment.
Great work though when testing this I'm running into the following error
Traceback (most recent call last):
File "/var/home/hayley/splashkit-core/test.py", line 1, in <module>
from splashkit import *
ImportError: /var/home/hayley/splashkit-core/env/lib64/python3.12/site-packages/splashkit.cpython-312-x86_64-linux-gnu.so: undefined symbol: _Z14SPLASHKIT_MAINv
A couple of other things to note:
- Python is moving away from setup.py to a new packaging format specified in PEP 517. As such the packaging scene in python is a bit of a mess at the moment. With that said for this initial implementation I think it's probably fine to stick with setup.py
- Could you move the commits fixing the spelling mistakes to a different PR as they aren't related to the python package?
Author
|
Hi, I've updated the code, can you review it again? |
|
I'm not sure if it's just my machine but I'm still getting the same error. I tried changing the source and include paths to be |
ede2031 to
516b5c5
Compare
516b5c5 to
5027c9d
Compare
…into pr/DarrenSunandar/65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create Python PIP Package.
Fixes # (issue)
Type of change
How Has This Been Tested?
To verify the changes made to the SplashKit Python package, I conducted several tests to ensure its functionality. After building the package locally, I installed it using 'pip install' . and confirmed that the installation process completed successfully without errors. I then created a Python script to import the splashkit module and tested various functions to ensure they operated as expected. To reproduce these tests, follow these steps:
Testing Checklist
Checklist