Skip to content

Create Python PIP Package#65

Merged
omckeon merged 3 commits intothoth-tech:python-pip-packagefrom
DarrenSunandar:create-python-pip
Jul 4, 2025
Merged

Create Python PIP Package#65
omckeon merged 3 commits intothoth-tech:python-pip-packagefrom
DarrenSunandar:create-python-pip

Conversation

@DarrenSunandar
Copy link
Copy Markdown

Description

Create Python PIP Package.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

To verify the changes made to the SplashKit Python package, I conducted several tests to ensure its functionality. After building the package locally, I installed it using 'pip install' . and confirmed that the installation process completed successfully without errors. I then created a Python script to import the splashkit module and tested various functions to ensure they operated as expected. To reproduce these tests, follow these steps:

  1. Navigate to the root directory of the project and run 'pip install .' to install the package.
  2. Create a Python script and include the line import splashkit.
  3. Call different functions provided by the splashkit module to verify they work correctly.

Testing Checklist

  • Tested with sktest
  • Tested with skunit_tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

Copy link
Copy Markdown

@hugglesfox hugglesfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work though when testing this I'm running into the following error

Traceback (most recent call last):
  File "/var/home/hayley/splashkit-core/test.py", line 1, in <module>
    from splashkit import *
ImportError: /var/home/hayley/splashkit-core/env/lib64/python3.12/site-packages/splashkit.cpython-312-x86_64-linux-gnu.so: undefined symbol: _Z14SPLASHKIT_MAINv

A couple of other things to note:

  • Python is moving away from setup.py to a new packaging format specified in PEP 517. As such the packaging scene in python is a bit of a mess at the moment. With that said for this initial implementation I think it's probably fine to stick with setup.py
  • Could you move the commits fixing the spelling mistakes to a different PR as they aren't related to the python package?

@DarrenSunandar
Copy link
Copy Markdown
Author

Hi, I've updated the code, can you review it again?

@hugglesfox
Copy link
Copy Markdown

I'm not sure if it's just my machine but I'm still getting the same error. I tried changing the source and include paths to be generated/cpp. If you're able to provide proof of it running then I'm happy to accept the PR. Sorry about the fuss.

@omckeon omckeon changed the base branch from main to python-pip-package July 4, 2025 04:29
@omckeon omckeon force-pushed the create-python-pip branch from ede2031 to 516b5c5 Compare July 4, 2025 04:38
@omckeon omckeon force-pushed the create-python-pip branch from 516b5c5 to 5027c9d Compare July 4, 2025 04:38
@omckeon omckeon merged commit e7a7e8e into thoth-tech:python-pip-package Jul 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants