Skip to content

Fix camera link#706

Open
abdullah12121212 wants to merge 2 commits intothoth-tech:mainfrom
abdullah12121212:fix-camera-link
Open

Fix camera link#706
abdullah12121212 wants to merge 2 commits intothoth-tech:mainfrom
abdullah12121212:fix-camera-link

Conversation

@abdullah12121212
Copy link
Copy Markdown

Description

Fixed a broken link in the sidebar navigation for the "SplashKit Camera" guide. The link was pointing to guides/input/using-splashkit-camera which does not exist, causing a 404 error. Updated it to the correct path guides/camera/using-splashkit-camera.

Please include a summary of the changes and the related issue. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

How Has This Been Tested?

Clicked the "SplashKit Camera" link in the sidebar and confirmed it navigates to the correct page without a 404 error.

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration.

Testing Checklist

  • Tested in latest Chrome
  • Tested in latest Firefox
  • npm run build
  • npm run preview

Checklist

Please delete options that are not relevant.

If involving code

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

If modified config files

  • I have checked the following files for changes:
    • package.json
    • astro.config.mjs
    • netlify.toml
    • docker-compose.yml
    • custom.css

Folders and Files Added/Modified

Please list the folders and files added/modified with this pull request and delete options that are not relevant.

  • Modified:
    • src/content/docs/guides/Camera/using-splashkit-camera.mdx

Additional Notes

Please add any additional information that might be useful for the reviewers.

No functional or visual changes, only the sidebar link path was corrected.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 26, 2026

Deploy Preview for splashkit failed.

Name Link
🔨 Latest commit 31f91d3
🔍 Latest deploy log https://app.netlify.com/projects/splashkit/deploys/69c4c4a2012cae000804248c

Copy link
Copy Markdown

@ralphweng-autograb ralphweng-autograb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review has been moved to the correct account (ralphweng2023). Please disregard.

Copy link
Copy Markdown

@222448082Ashen 222448082Ashen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Description

  • Title: Fix camera link
  • Author Description: Fixed a broken link in the sidebar navigation for the "SplashKit Camera" guide. The link was pointing to guides/input/using-splashkit-camera, which does not exist, causing a 404 error. Updated it to the correct path guides/camera/using-splashkit-camera.
  • Type of Change: Bug fix (Documentation)

Peer-Review Checklist

Functionality & Testing

  • Verified Sidebar Link: The link in astro.config.mjs was updated from guides/input/using-splashkit-camera to guides/camera/using-splashkit-camera.
  • Path Validation:
    • Verified the directory structure: src/content/docs/guides/Camera/using-splashkit-camera.mdx exists.
    • Note: On Windows, the folder is named Camera (capitalised), but Astro/Starlight handles case-insensitive routing for paths. The link guides/camera/using-splashkit-camera will correctly resolve to the file.
  • Build Verification: The change is a string update in a configuration file and does not introduce any structural risks.

Specific File Review

astro.config.mjs

  • Correctness: The change accurately reflects the actual location of the camera guide within the src/content/docs/guides/ directory.

Reviewer Notes

The fix is straightforward and correctly addresses a 404 error in the production/development sidebar. The PR also includes some minor import reordering and turns on strict link validation by default, which is a good practice for project health.

Copy link
Copy Markdown

@ralphweng2023 ralphweng2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer Review

I've reviewed this PR and confirmed it addresses two small but valid issues:

  1. Camera guide link fix — The sidebar link was pointing to guides/input/using-splashkit-camera instead of the correct guides/camera/using-splashkit-camera. Good catch.

  2. Typo fixseperatelyseparately in the interface guide.

Both changes are straightforward and correct. LGTM.

Checks

  • Link fix verified — guides/camera/using-splashkit-camera is the correct path for the camera guide
  • Typo fix is correct
  • No unintended whitespace-only changes (the brace formatting on line 114 is a minor style normalisation, which is fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants