fix: make check-links script cross-platform#714
Open
Osaid2993 wants to merge 1 commit intothoth-tech:mainfrom
Open
fix: make check-links script cross-platform#714Osaid2993 wants to merge 1 commit intothoth-tech:mainfrom
Osaid2993 wants to merge 1 commit intothoth-tech:mainfrom
Conversation
❌ Deploy Preview for splashkit failed.
|
|
Hi, I reviewed your PR and it looks good overall.
I noticed the checks are failing, but it seems related to existing build or link issues rather than this specific change. One small suggestion:
Overall, this is a clean and useful fix. Good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 'npm run check-links' so it actually works on Mac, Linux, and the dev container
The script was using 'SET' to define an environment variable, which is Windows-only. On Unix-like systems it just fails immediately with 'SET: not found', the build never even starts.
Type of change
How Has This Been Tested?
I tested this by running:
npm run check-linksAfter the fix, the script runs correctly and reaches the link-validation stage of the build. The remaining failure is from existing invalid hash links like '/api/geometry/#rectangle-around', not from the 'check-links' script itself.
Checklist
If involving code
If modified config files
Folders and Files Added/Modified
Additional Notes
This PR is intentionally limited to
package.jsonso the cross-platform script fix stays separate from the repository’s existing build and link validation issues.