Add resume_timer usage example#724
Open
himanshigaba22 wants to merge 2 commits intothoth-tech:mainfrom
Open
Conversation
❌ Deploy Preview for splashkit failed.
|
kottochii
suggested changes
Apr 7, 2026
kottochii
left a comment
kottochii
left a comment
There was a problem hiding this comment.
I suggest the auto-generated parts in the JSON files.
Also, please see the resume_timer's C# examples for the suggested changes (referring to the ambiguity of the file).
| static void Main(string[] args) | ||
| { | ||
| // Create and start a timer | ||
| Timer myTimer = SplashKit.CreateTimer("my_timer"); |
There was a problem hiding this comment.
Use of Timer without preceding SplashKitSDK.Timer causes ambiguity with the system class of a similar name.
| using static SplashKitSDK.SplashKit; | ||
|
|
||
| // Create and start a timer | ||
| Timer myTimer = CreateTimer("my_timer"); |
There was a problem hiding this comment.
Remove this file, as it is not related to the commit.
There was a problem hiding this comment.
Only leave the changes directly related to the functions you are committing.
Author
There was a problem hiding this comment.
Hi! I have addressed all the review comments:
- Fixed Timer ambiguity in both C# files using SplashKitSDK.Timer
- The replace_all files and JSON changes appearing in this PR
are from my previous replace_all PR which hasn't been merged
into thoth-tech:main yet. My branch itself only contains
resume_timer files — there are no unrelated changes in my branch.
Please let me know if anything else needs changing. Thank you!
himanshigaba22
force-pushed
the
resume-timer-usage-example
branch
from
adf51be to
e6c6d0e
Compare
himanshigaba22
force-pushed
the
resume-timer-usage-example
branch
from
e6c6d0e to
b2a23ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds usage example for the
resume_timerfunction from SplashKit Timers API.Type of Change
Usage Example Details
Checklist