Adds basic support for queries generated by #find_by_sql
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #32 Allows exporting data that was generated by [find_by_sql][]. This can be desirable when the caller is required to export a calculated field that is not stored directly on the table as demonstrated below. ```ruby User.find_by_sql("SELECT id, 'custom_value' AS custom_field FROM users") ArtVandelay::Export.new(export).csv ``` As such, this feature does not support the `in_batches_of` option, since that would be the responsibility of the query. This feature also does not (yet) support the `attributes` option. [find_by_sql]: https://api.rubyonrails.org/classes/ActiveRecord/Querying.html#method-i-find_by_sql
The previous commit failed to account for the case where `#find_by_sql` returns no results.
stevepolitodesign
force-pushed
the
sp-support-find-by-sql
branch
from
7532a93 to
189693b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #32
Allows exporting data that was generated by find_by_sql. This can be desirable when the caller is required to export a calculated field that is not stored directly on the table as demonstrated below.
As such, this feature does not support the
in_batches_ofoption, sincethat would be the responsibility of the query.
This feature also does not (yet) support the
attributesoption.