Skip to content

Added the ability to handle a database url in database.yml #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added the ability to handle a database url in database.yml #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db5d405
Added the ability to handle a database url in database.yml
fearoffish Mar 26, 2020
962681a
Changes to satisfy the hound
fearoffish Mar 26, 2020
af81b54
Added a note to the README that we can use database url
fearoffish Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ heroku git:remote -r staging -a your-staging-app
heroku git:remote -r production -a your-production-app
```
* There is a `config/database.yml` file that can be parsed as YAML for
`['development']['database']`.
`['development']['database']` or `['development']['url']`.

Pipelines
---------
Expand Down
12 changes: 9 additions & 3 deletions lib/parity/backup.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ class Backup
DATABASE_YML_RELATIVE_PATH = "config/database.yml".freeze
DEVELOPMENT_ENVIRONMENT_KEY_NAME = "development".freeze
DATABASE_KEY_NAME = "database".freeze
DATABASE_URL_KEY_NAME = "url".freeze

def initialize(args)
@from, @to = args.values_at(:from, :to)
Expand Down Expand Up @@ -108,9 +109,14 @@ def remote_db_backup_url
end

def development_db
YAML.load(database_yaml_file).
fetch(DEVELOPMENT_ENVIRONMENT_KEY_NAME).
fetch(DATABASE_KEY_NAME)
environment_block = YAML.safe_load(database_yaml_file).
fetch(DEVELOPMENT_ENVIRONMENT_KEY_NAME)
if environment_block.key?(DATABASE_KEY_NAME)
environment_block.fetch(DATABASE_KEY_NAME)
elsif environment_block.key?(DATABASE_URL_KEY_NAME)
url = environment_block.fetch(DATABASE_URL_KEY_NAME)
URI(url).path.tr("/", "")
end
end

def database_yaml_file
Expand Down