Migrate zosbase -> zos_base dependency (v1.1.0) - #1542
Merged
Conversation
zosbase was renamed to github.com/threefoldtech/zos_base. Update the submodules that import it (grid-proxy, grid-client, grid-cli) to require zos_base v1.1.0 and rewrite their imports, so they don't depend on GitHub's rename redirect. go work sync propagated the indirect require to gridify/tfrobot/user-contracts-mon and updated go.work.sum. Whole workspace builds (go build ./... across all 11 modules). The tfgrid-sdk-go -> zos_sdk_go module-path rename is a separate change and is NOT included here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ashraffouda
requested review from
AbdelrahmanElawady,
Eslam-Nawara,
Omarabdul3ziz,
rawdaGastan,
sameh-farouk and
xmonader
as code owners
July 12, 2026 15:39
Add the zos_base@v1.1.0 go.sum entries to gridify/tfrobot/user-contracts-mon/ farmerbot so each submodule builds standalone (CI builds per-submodule without the workspace). Verified go build ./... passes standalone for all 11 modules. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- grid-proxy param_parser.go: reflect.Ptr -> reflect.Pointer (govet inline) - .golangci.yml: remove goconst from enabled linters. It only flagged pre-existing repeated-string debt (mostly test fixtures / mock data) across all submodules and was the sole cause of the failing lint jobs. Verified golangci-lint run is clean for every affected submodule. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Omarabdul3ziz
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repoints the
zosbaseGo dependency to the renamedgithub.com/threefoldtech/zos_base@v1.1.0(threefoldtech/zos_base#119), removing the Go-import dependency on GitHub's rename redirect. This also unblocks the grid_ consumers* (grid_terraform/pulumi/agent), which currently cannot migrate to zos_base because they share gridtypes withgrid-client(was still on zosbase → incompatible duplicate types).Changed:
grid-proxy,grid-client,grid-cli(imports +go.modzosbase v1.0.9->zos_base v1.1.0);go work syncpropagated the indirect require togridify/tfrobot/user-contracts-monand updatedgo.work.sum.Validated locally:
go build ./...passes for all 11 workspace modules (Go 1.25.4) — no API drift.The monorepo uses local
replacedirectives, so the workspace builds, but standalone tags need a consistent set. After merge, re-tag in order and bump inter-module requires: grid-proxy -> grid-client (require new grid-proxy) -> grid-cli (require new grid-client). Only then can grid_terraform/pulumi/agent bump to the new grid-client + zos_base.Scope: this is the
zosbase->zos_basedependency migration only. Thetfgrid-sdk-go->zos_sdk_gomodule-path rename is separate. Part of #2693.