Build previews using dapp-development-goerli packages
#161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**BACKGROUND:** There are situations when team developing T Token Dashboard needs to locally test some functionalities using modified contracts, for example ones with shorter authorization decrease delay. We decided to create a `dapp-development` branch in each of the expected upstream modules of the `threshold-network/token-dashboard` CI module, which would store the code of these modified contracts. (Although currently there's no `@keep-network/random-beacon`, `@keep-network/ecdsa` and `@keep-network/tbtc-v2` dependencies in the T dashboard yet, they're expected to be added soon and we are already preparing for that). Repositories with `dapp-development` branch containing modified contracts: `threshold-network/solidity-contracts` `keep-network/keep-core` `keep-network/tbtc-v2` Using the code from the `dapp-development` branch we will build packages that will be published to the NPM registry under `dapp-development-<environment>` tag and with `dapp-dev-<environment>` suffix (`<environment>` currently being `goerli`). Generally, the goal of the changes is to have the full set of dapp-development-friendly contracts deployed to the NPM registry, so that they could be used to create dApp previews that will be easily testable. The dApp developers could also use the contracts to build dashboard on their local envirionment by upgrading the `token-dashboard` dependencies using `yarn upgrade <package-name>@dapp-development-goerli`. **THIS CHANGE:** in this commit we configure the `dashboard-ci.yml` workflow to use the packages tagged `dapp-dev-goerli` when building PR previews.
michalinacienciala
requested review from
pdyraga,
nkuba and
lukasz-zimnoch
as code owners
2 tasks
9 tasks
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-dapp-dev-2/index.html. |
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-dapp-dev-2/index.html. |
1 similar comment
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-dapp-dev-2/index.html. |
nkuba
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
There are situations when team developing T Token Dashboard needs to
locally test some functionalities using modified contracts, for example
ones with shorter authorization decrease delay. We decided to create a
dapp-developmentbranch in each of the expected upstream modules ofthe
threshold-network/token-dashboardCI module, which would storethe code of these modified contracts. (Although currently there's no
@keep-network/random-beacon,@keep-network/ecdsaand@keep-network/tbtc-v2dependencies in the T dashboard yet, they'reexpected to be added soon and we are already preparing for that).
Repositories with
dapp-developmentbranch containing modifiedcontracts:
threshold-network/solidity-contractskeep-network/keep-corekeep-network/tbtc-v2Using the code from the
dapp-developmentbranch we will buildpackages that will be published to the NPM registry under
dapp-development-<environment>tag and withdapp-development-<environment>suffix (
<environment>currently beinggoerli).Generally, the goal of the changes is to have the full set of
dapp-development-friendly contracts deployed to the NPM registry, so
that they could be used to create dApp previews that will be easily
testable. The dApp developers could also use the contracts to build
dashboard on their local envirionment by upgrading the
token-dashboarddependencies usingyarn upgrade <package-name>@dapp-development-goerli.THIS CHANGE:
In this commit we configure the
dashboard-ci.ymlworkflow to use thepackages tagged
dapp-development-goerliwhen building PR previews.We also upgrade actions to newer versions.
Refs:
#136
threshold-network/solidity-contracts#119
threshold-network/keep-core#3121
threshold-network/tbtc-v2#392