Skip to content

Editor: Unable to undo creation of Component #1189 #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eprikazchikov merged 1 commit into from
Dec 18, 2025
Merged

Editor: Unable to undo creation of Component #1189 #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions engine/src/components/spriterender.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ SpriteRender::SpriteRender() :
m_mesh(PipelineContext::defaultPlane()),
m_customMesh(Engine::objectCreate<Mesh>()),
m_drawMode(Simple),
m_priority(0),
m_useCustom(false),
m_dirtyMesh(true),
m_dirtyMaterial(true) {
Expand Down
9 changes: 5 additions & 4 deletions worldeditor/src/screens/scenecomposer/actions/createcomponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@ CreateComponent::CreateComponent(const TString &type, Object *object, ObjectCont
UndoCommand(QObject::tr("Create %1").arg(type.data()).toStdString(), group),
m_type(type),
m_controller(ctrl),
m_object(object->uuid()) {
m_object(object->uuid()),
m_component(0) {

}

void CreateComponent::undo() {
for(auto uuid : m_objects) {
Object *object = Engine::findObject(uuid);
if(m_component) {
Object *object = Engine::findObject(m_component);
if(object) {
delete object;

Expand All @@ -28,7 +29,7 @@ void CreateComponent::redo() {
Component *component = dynamic_cast<Component *>(Engine::objectCreate(m_type, m_type, parent));
if(component) {
component->composeComponent();
m_objects.push_back(component->uuid());
m_component = component->uuid();

emit m_controller->objectsSelected({Engine::findObject(m_object)});
}
Expand Down
3 changes: 2 additions & 1 deletion worldeditor/src/screens/scenecomposer/actions/createcomponent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ class CreateComponent : public UndoCommand {
void redo() override;

protected:
std::list<uint32_t> m_objects;

TString m_type;

ObjectController *m_controller;

uint32_t m_object;
uint32_t m_component;

};

Expand Down
Loading