Update encoding to use locale based detection when parsing logs #10
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=========================================
- Coverage 4.31% 4.30% -0.01%
=========================================
Files 175 175
Lines 81020 81022 +2
=========================================
Hits 3492 3492
- Misses 77528 77530 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kuqin12
force-pushed
the
update_encoding_bt
branch
from
2a63a9e to
f877898
Compare
| if MemTo is not None: | ||
| if "Note: including file:" == LineStr.lstrip()[:21]: | ||
| if "Note: including file:" == LineStr.lstrip()[:21] or\ | ||
| "注意: 包含文件: " == LineStr.lstrip()[:10]: |
There was a problem hiding this comment.
what is this?
Do we need this in all supported languages?
There was a problem hiding this comment.
That is the Chinese counterpart of "Note: including file" lines from compiler. It will spew many lines for each c file it built. I think that's why it was there in the first place. Do you know by chance where to look up this information, other than testing installation on all locales? (I think this is specific to CL)
|
This has been open for a while. Is it still required? |
ghost
requested review from
Update encoding to use locale based detection when parsing logs.
This change also added the log handling/filtering of Chinese characters that was generated by VC compilers.